Re: Write visibility map during CLUSTER/VACUUM FULL

2022-06-30 Thread Jacob Champion
Justin Pryzby wrote: > I'm planning to close this patch until someone can shepherd it. I've marked it RwF for now. --Jacob

Re: Write visibility map during CLUSTER/VACUUM FULL

2022-01-27 Thread Justin Pryzby
On Sun, Dec 26, 2021 at 08:59:31PM -0600, Justin Pryzby wrote: > Rebased on 8e1fae193864527c931a704bd7908e4fbc983f5c. > > Would someone step up to "own" this patch ? > > If not, its CF entry may need to be closed (there's no status for "needs > author"). I'm planning to close this patch until so

Re: Write visibility map during CLUSTER/VACUUM FULL

2021-12-26 Thread Justin Pryzby
On Mon, Nov 15, 2021 at 04:38:56PM -0600, Justin Pryzby wrote: > On Sun, Aug 29, 2021 at 07:26:42PM -0500, Justin Pryzby wrote: > > On Mon, Jun 28, 2021 at 11:22:01AM +0300, Anna Akenteva wrote: > > > On 2019-11-29 05:32, Michael Paquier wrote: > > > > These comments are unanswered for more than 2

Re: Write visibility map during CLUSTER/VACUUM FULL

2021-11-15 Thread Justin Pryzby
On Sun, Aug 29, 2021 at 07:26:42PM -0500, Justin Pryzby wrote: > On Mon, Jun 28, 2021 at 11:22:01AM +0300, Anna Akenteva wrote: > > On 2019-11-29 05:32, Michael Paquier wrote: > > > These comments are unanswered for more than 2 months, so I am marking > > > this entry as returned with feedback. > >

Re: Write visibility map during CLUSTER/VACUUM FULL

2021-11-15 Thread Daniel Gustafsson
> On 30 Aug 2021, at 02:26, Justin Pryzby wrote: > Rebased on f10f0ae420ee62400876ab34dca2c09c20dcd030. This patch no longer applies, please submit a rebased version. -- Daniel Gustafsson https://vmware.com/

Re: Write visibility map during CLUSTER/VACUUM FULL

2021-08-29 Thread Justin Pryzby
On Mon, Jun 28, 2021 at 11:22:01AM +0300, Anna Akenteva wrote: > On 2019-11-29 05:32, Michael Paquier wrote: > > These comments are unanswered for more than 2 months, so I am marking > > this entry as returned with feedback. > > I'd like to revive this patch. To make further work easier, attaching

Re: Write visibility map during CLUSTER/VACUUM FULL

2021-07-14 Thread vignesh C
On Mon, Jun 28, 2021 at 1:52 PM Anna Akenteva wrote: > > On 2019-11-29 05:32, Michael Paquier wrote: > > These comments are unanswered for more than 2 months, so I am marking > > this entry as returned with feedback. > > I'd like to revive this patch. To make further work easier, attaching a > reb

Re: Write visibility map during CLUSTER/VACUUM FULL

2021-06-28 Thread Anna Akenteva
On 2019-11-29 05:32, Michael Paquier wrote: These comments are unanswered for more than 2 months, so I am marking this entry as returned with feedback. I'd like to revive this patch. To make further work easier, attaching a rebased version of the latest patch by Alexander. As for having yet

Re: Write visibility map during CLUSTER/VACUUM FULL

2019-11-28 Thread Michael Paquier
On Fri, Sep 20, 2019 at 01:05:06PM -0700, Andres Freund wrote: > I don't think we should have yet another copy of logic determining > visibility. It has repeatedly proven hard to get right in the past, and > it'll not get better by having yet another copy. Especially not because > we've basically

Re: Write visibility map during CLUSTER/VACUUM FULL

2019-09-20 Thread Andres Freund
Hi, On 2019-09-13 22:22:50 +0300, Alexander Korotkov wrote: > On Thu, Sep 12, 2019 at 4:55 PM Alexander Korotkov > wrote: > > On Wed, Sep 11, 2019 at 3:30 PM Amit Kapila wrote: > > > On Sun, Sep 1, 2019 at 1:37 PM Alexander Korotkov > > > wrote: > > > > I found it weird that CLUSTER/VACUUM FULL

Re: Write visibility map during CLUSTER/VACUUM FULL

2019-09-13 Thread Alexander Korotkov
On Thu, Sep 12, 2019 at 4:55 PM Alexander Korotkov wrote: > On Wed, Sep 11, 2019 at 3:30 PM Amit Kapila wrote: > > On Sun, Sep 1, 2019 at 1:37 PM Alexander Korotkov > > wrote: > > > I found it weird that CLUSTER/VACUUM FULL don't write visibility map. > > > Attached patch implements writing visi

Re: Write visibility map during CLUSTER/VACUUM FULL

2019-09-12 Thread Alexander Korotkov
On Wed, Sep 11, 2019 at 3:30 PM Amit Kapila wrote: > On Sun, Sep 1, 2019 at 1:37 PM Alexander Korotkov > wrote: > > I found it weird that CLUSTER/VACUUM FULL don't write visibility map. > > Attached patch implements writing visibility map in > > heapam_relation_copy_for_cluster(). > > > > I've st

Re: Write visibility map during CLUSTER/VACUUM FULL

2019-09-11 Thread Amit Kapila
On Sun, Sep 1, 2019 at 1:37 PM Alexander Korotkov wrote: > > Hi! > > I found it weird that CLUSTER/VACUUM FULL don't write visibility map. > Attached patch implements writing visibility map in > heapam_relation_copy_for_cluster(). > > I've studied previous attempt to implement this [1]. The main

Re: Write visibility map during CLUSTER/VACUUM FULL

2019-09-01 Thread Alexander Korotkov
On Sun, Sep 1, 2019 at 11:07 AM Alexander Korotkov wrote: > This patch have to implement its own check if tuple is allvisible. > But it appears to be possible to simplify this check assuming that all > tuples already past HeapTupleSatisfiesVacuum(), which sets hint bits. Forgot to check tuple xmi

Write visibility map during CLUSTER/VACUUM FULL

2019-09-01 Thread Alexander Korotkov
Hi! I found it weird that CLUSTER/VACUUM FULL don't write visibility map. Attached patch implements writing visibility map in heapam_relation_copy_for_cluster(). I've studied previous attempt to implement this [1]. The main problem of that attempt was usage of existing heap_page_is_all_visible()