Re: Windows crash / abort handling

2022-02-03 Thread David Rowley
On Thu, 3 Feb 2022 at 15:38, Andres Freund wrote: > I've pushed the patch this thread is about now. Lets see what the buildfarm > says. I only could one windows version. Separately I've also pushed a patch > to run the windows tests under a timeout. I hope in combination these patches > address t

Re: Windows crash / abort handling

2022-02-02 Thread Andres Freund
Hi, On 2022-02-02 11:24:19 +1300, Thomas Munro wrote: > On Sun, Jan 30, 2022 at 10:02 AM Andres Freund wrote: > > On 2022-01-09 16:57:04 -0800, Andres Freund wrote: > > > I've attached a patch implementing these changes. > > > > Unless somebody is planning to look at this soon, I'm planning to pu

Re: Windows crash / abort handling

2022-02-01 Thread Thomas Munro
On Sun, Jan 30, 2022 at 10:02 AM Andres Freund wrote: > On 2022-01-09 16:57:04 -0800, Andres Freund wrote: > > I've attached a patch implementing these changes. > > Unless somebody is planning to look at this soon, I'm planning to push it to > master. It's too annoying to have these hangs and not

Re: Windows crash / abort handling

2022-01-29 Thread Andres Freund
Hi, On 2022-01-09 16:57:04 -0800, Andres Freund wrote: > I've attached a patch implementing these changes. Unless somebody is planning to look at this soon, I'm planning to push it to master. It's too annoying to have these hangs and not see backtraces. We're going to have to do this in all bin

Re: Windows crash / abort handling

2022-01-11 Thread Andrew Dunstan
On 1/11/22 16:13, Andres Freund wrote: > Hi, > > On 2022-01-11 12:01:42 -0500, Andrew Dunstan wrote: >> On 1/11/22 02:51, Andres Freund wrote: >>> It'd be a bit of a fight with cdb's awfully documented and quirky >>> scripting [1], but the best solution would probably be to just use an >>> enviro

Re: Windows crash / abort handling

2022-01-11 Thread Andres Freund
Hi, On 2022-01-11 12:01:42 -0500, Andrew Dunstan wrote: > On 1/11/22 02:51, Andres Freund wrote: > > It'd be a bit of a fight with cdb's awfully documented and quirky > > scripting [1], but the best solution would probably be to just use an > > environment variable from the target process to deter

Re: Windows crash / abort handling

2022-01-11 Thread Andrew Dunstan
On 1/11/22 02:51, Andres Freund wrote: > Hi, > > On 2022-01-10 10:57:00 -0500, Andrew Dunstan wrote: >> On 10/5/21 15:30, Andres Freund wrote >>> The above ends up dumping all crashes into a single file, but that can >>> probably be improved. But cdb is so gnarly that I wanted to stop looking >>

Re: Windows crash / abort handling

2022-01-10 Thread Andres Freund
Hi, On 2022-01-10 10:57:00 -0500, Andrew Dunstan wrote: > On 10/5/21 15:30, Andres Freund wrote > > The above ends up dumping all crashes into a single file, but that can > > probably be improved. But cdb is so gnarly that I wanted to stop looking > > once > > I got this far... FWIW, I figured o

Re: Windows crash / abort handling

2022-01-10 Thread Andrew Dunstan
On 10/5/21 15:30, Andres Freund wrote > > To actually get the crash reports I ended up doing the following on the OS > level [5]: > > Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Windows > NT\CurrentVersion\AeDebug' -Name 'Debugger' -Value '\"C:\Windows > Kits\10\Debuggers\x64\cdb.exe\"

Re: Windows crash / abort handling

2022-01-09 Thread Andres Freund
Hi, On 2021-10-06 14:11:51 +0800, Craig Ringer wrote: > On Wed, 6 Oct 2021, 03:30 Andres Freund, wrote: > > > Hi, > > > > > > My first attempt was to try to use the existing crashdump stuff in > > pgwin32_install_crashdump_handler(). That's not really quite what I want, > > because it only handle

Re: Windows crash / abort handling

2021-10-05 Thread Craig Ringer
On Wed, 6 Oct 2021, 03:30 Andres Freund, wrote: > Hi, > > > My first attempt was to try to use the existing crashdump stuff in > pgwin32_install_crashdump_handler(). That's not really quite what I want, > because it only handles postmaster rather than any binary, but I thought > it'd > be a good

Windows crash / abort handling

2021-10-05 Thread Andres Freund
Hi, As threatened in [1]... For CI, originally in the AIO project but now more generally, I wanted to get windows backtraces as part of CI. I also was confused why visual studio's "just in time debugging" (i.e. a window popping up offering to debug a process when it crashes) didn't work with postg