Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Pantelis Theodosiou
On Tue, May 15, 2018 at 6:29 PM, Tom Lane wrote: > Mark Dilger writes: > > > I don't have a strong opinion on that. I could also look to upgrade > > to a newer version. Generally, I try to build using the oldest > > supported version rather than the newest. What is the next oldest > > working

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Andrew Dunstan
On 05/15/2018 01:20 PM, Tom Lane wrote: Mark Dilger writes: If none of the animals are configured to detect this bug, perhaps the community needs another Windows animal configured along the lines of the build machine I am using? +1. How do you have yours configured, anyway? I mostly develo

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Tom Lane
Mark Dilger writes: >> On May 15, 2018, at 10:20 AM, Tom Lane wrote: >> Hm. I'm not sure what our nominal support range for Visual Studio is. >> I see that mastodon (running VS2005) and currawong (running VS2008) >> haven't reported on HEAD lately, and I think they may have been shut >> down int

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Mark Dilger
> On May 15, 2018, at 10:20 AM, Tom Lane wrote: > > Mark Dilger writes: If none of the animals are configured to detect this bug, perhaps the community needs another Windows animal configured along the lines of the build machine I am using? > >>> +1. How do you have yours confi

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Tom Lane
Mark Dilger writes: >>> If none of the animals >>> are configured to detect this bug, perhaps the community needs another >>> Windows animal configured along the lines of the build machine I am using? >> +1. How do you have yours configured, anyway? > I mostly develop on mac and linux and don't

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Mark Dilger
> On May 15, 2018, at 9:54 AM, Tom Lane wrote: > > Mark Dilger writes: >> I'm curious why the Windows build farm members did not pick this up. Or >> perhaps they did? (I don't get emails about that.) > > They did not, and I too was wondering why not. > >> If none of the animals >> are confi

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Tom Lane
Mark Dilger writes: > I'm curious why the Windows build farm members did not pick this up. Or > perhaps they did? (I don't get emails about that.) They did not, and I too was wondering why not. > If none of the animals > are configured to detect this bug, perhaps the community needs another >

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Mark Dilger
> On May 15, 2018, at 9:29 AM, Stephen Frost wrote: > > Greetings, > > * Mark Dilger (hornschnor...@gmail.com) wrote: >>> On May 15, 2018, at 8:58 AM, Tom Lane wrote: >>> Mark Dilger writes: My best guess at the moment is: >>> diff --git a/src/backend/utils/init/globals.c b/s

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Stephen Frost
Greetings, * Mark Dilger (hornschnor...@gmail.com) wrote: > > On May 15, 2018, at 8:58 AM, Tom Lane wrote: > > Mark Dilger writes: > >> My best guess at the moment is: > > > >> diff --git a/src/backend/utils/init/globals.c > >> b/src/backend/utils/init/globals.c > >> index c1f0441b08..0a316339

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Mark Dilger
> On May 15, 2018, at 8:58 AM, Tom Lane wrote: > > Mark Dilger writes: >> My best guess at the moment is: > >> diff --git a/src/backend/utils/init/globals.c >> b/src/backend/utils/init/globals.c >> index c1f0441b08..0a3163398f 100644 >> --- a/src/backend/utils/init/globals.c >> +++ b/src/back

Re: Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Tom Lane
Mark Dilger writes: > My best guess at the moment is: > diff --git a/src/backend/utils/init/globals.c > b/src/backend/utils/init/globals.c > index c1f0441b08..0a3163398f 100644 > --- a/src/backend/utils/init/globals.c > +++ b/src/backend/utils/init/globals.c > @@ -16,8 +16,11 @@ > * > *-

Windows build broken starting at da9b580d89903fee871cf54845ffa2b26bda2e11

2018-05-15 Thread Mark Dilger
Hackers, There was a bug report sent by Hao Lee about Windows build breakage, "BUG #15167: error C2365: 'errcode' : redefinition; previous definition" https://www.postgresql.org/message-id/152446498404.19807.4659286570762153837%40wrigleys.postgresql.org Heikki was the only person who responded to