Re: Why doesn't Vacuum FULL update the VM

2023-09-03 Thread Melanie Plageman
On Fri, Sep 1, 2023 at 8:38 PM Peter Geoghegan wrote: > > On Fri, Sep 1, 2023 at 12:34 PM Melanie Plageman > wrote: > > I don't see why the visibility map shouldn't be updated so that all of > > the pages show all visible and all frozen for this relation after the > > vacuum full. > > There was a

Re: Why doesn't Vacuum FULL update the VM

2023-09-01 Thread Peter Geoghegan
On Fri, Sep 1, 2023 at 12:34 PM Melanie Plageman wrote: > I don't see why the visibility map shouldn't be updated so that all of > the pages show all visible and all frozen for this relation after the > vacuum full. There was a similar issue with COPY FREEZE. It was fixed relatively recently -- s

Re: Why doesn't Vacuum FULL update the VM

2023-09-01 Thread Vik Fearing
On 9/1/23 21:34, Melanie Plageman wrote: Hi, I noticed that VACUUM FULL actually does freeze the tuples in the rewritten table (heap_freeze_tuple()) but then it doesn't mark them all visible or all frozen in the visibility map. I don't understand why. It seems like it would save us future work.

Why doesn't Vacuum FULL update the VM

2023-09-01 Thread Melanie Plageman
Hi, I noticed that VACUUM FULL actually does freeze the tuples in the rewritten table (heap_freeze_tuple()) but then it doesn't mark them all visible or all frozen in the visibility map. I don't understand why. It seems like it would save us future work. Here is an example: create extension pg_v