Re: We're leaking predicate locks in HEAD

2019-05-09 Thread Thomas Munro
On Wed, May 8, 2019 at 4:50 PM Thomas Munro wrote: > On Wed, May 8, 2019 at 3:53 PM Tom Lane wrote: > > Thomas Munro writes: > > > Reproduced here. Once the system reaches a state where it's leaking > > > (which happens only occasionally for me during installcheck-parallel), > > > it keeps leak

Re: We're leaking predicate locks in HEAD

2019-05-07 Thread Thomas Munro
On Wed, May 8, 2019 at 3:53 PM Tom Lane wrote: > Thomas Munro writes: > > Reproduced here. Once the system reaches a state where it's leaking > > (which happens only occasionally for me during installcheck-parallel), > > it keeps leaking for future SSI transactions. The cause is > > SxactGlobal

Re: We're leaking predicate locks in HEAD

2019-05-07 Thread Tom Lane
Thomas Munro writes: > Reproduced here. Once the system reaches a state where it's leaking > (which happens only occasionally for me during installcheck-parallel), > it keeps leaking for future SSI transactions. The cause is > SxactGlobalXmin getting stuck. The attached fixes it for me. I can'

Re: We're leaking predicate locks in HEAD

2019-05-07 Thread Thomas Munro
On Wed, May 8, 2019 at 6:56 AM Thomas Munro wrote: > On Wed, May 8, 2019 at 5:46 AM Tom Lane wrote: > > I'd have to say that my first suspicion falls on bb16aba50 ... > > Investigating. Reproduced here. Once the system reaches a state where it's leaking (which happens only occasionally for me d

Re: We're leaking predicate locks in HEAD

2019-05-07 Thread Tom Lane
Andrew Dunstan writes: > On 5/7/19 1:46 PM, Tom Lane wrote: >> After running the core regression tests with installcheck-parallel, >> the pg_locks view sometimes shows me apparently-orphaned SIReadLock >> entries. They accumulate over repeated test runs. > Should we have a test for that run at

Re: We're leaking predicate locks in HEAD

2019-05-07 Thread Andrew Dunstan
On 5/7/19 1:46 PM, Tom Lane wrote: > After running the core regression tests with installcheck-parallel, > the pg_locks view sometimes shows me apparently-orphaned SIReadLock > entries. They accumulate over repeated test runs. Should we have a test for that run at/near the end of the regress

Re: We're leaking predicate locks in HEAD

2019-05-07 Thread Thomas Munro
On Wed, May 8, 2019 at 5:46 AM Tom Lane wrote: > After running the core regression tests with installcheck-parallel, > the pg_locks view sometimes shows me apparently-orphaned SIReadLock > entries. [...] Ugh. > I'd have to say that my first suspicion falls on bb16aba50 ... Investigating. -- T

We're leaking predicate locks in HEAD

2019-05-07 Thread Tom Lane
After running the core regression tests with installcheck-parallel, the pg_locks view sometimes shows me apparently-orphaned SIReadLock entries. They accumulate over repeated test runs. Right now, for example, I see regression=# select * from pg_locks; locktype | database | relation | page |