Re: Warning -Wclobbered in PG_TRY(...)

2025-05-30 Thread Maxim Orlov
On Thu, 29 May 2025 at 18:26, Tom Lane wrote: > > Go there and use the "keyword search" for "longjmp" --- they > don't seem to make it possible to bookmark individual pages. > > Indeed, you are fully correct. I didn't analyse the code well enough. The equivalent code for PG_TRY/PG_FINALLY/PG_END_

Re: Warning -Wclobbered in PG_TRY(...)

2025-05-29 Thread Tom Lane
I wrote: > Really? I don't have a current C standard at hand, but POSIX-2024 [1] > claims to be aligned with the C standard for this, Ooops, forgot to attach the URL: [1] https://pubs.opengroup.org/onlinepubs/9799919799/ Go there and use the "keyword search" for "longjmp" --- they don't seem to

Re: Warning -Wclobbered in PG_TRY(...)

2025-05-29 Thread Tom Lane
Maxim Orlov writes: > On Thu, 29 May 2025 at 14:14, Tom Lane wrote: >> -Wclobbered would be really useful if it worked --- but sadly, >> on practically all gcc and clang versions, those warnings have >> nearly nothing to do with reality. We typically ignore them. > Yes, in the vast majority of

Re: Warning -Wclobbered in PG_TRY(...)

2025-05-29 Thread Maxim Orlov
On Thu, 29 May 2025 at 14:14, Tom Lane wrote: > -Wclobbered would be really useful if it worked --- but sadly, > on practically all gcc and clang versions, those warnings have > nearly nothing to do with reality. We typically ignore them. Yes, in the vast majority of cases. But I believe this

Re: Warning -Wclobbered in PG_TRY(...)

2025-05-29 Thread Tom Lane
m.litsa...@postgrespro.ru writes: > Does it makes sense to add volatile attribute to the _do_rethrow or > should we just ignore that -Wclobbered warning? -Wclobbered would be really useful if it worked --- but sadly, on practically all gcc and clang versions, those warnings have nearly nothing to

Warning -Wclobbered in PG_TRY(...)

2025-05-29 Thread m . litsarev
Hi, hackers! While building pg_duckdb extension with PostgreSQL 17.5 we found -Wclobbered warning from gcc with PG_TRY(): g++ -Wall -Wpointer-arith -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-