Re: Verbosity of genbki.pl

2018-04-30 Thread Peter Eisentraut
On 4/29/18 06:50, Michael Paquier wrote: > On Sat, Apr 28, 2018 at 01:02:10PM -0400, Stephen Frost wrote: >> +1 for making them not output anything if all is well. > > +1. done -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Trainin

Re: Verbosity of genbki.pl

2018-04-29 Thread Michael Paquier
On Sat, Apr 28, 2018 at 01:02:10PM -0400, Stephen Frost wrote: > +1 for making them not output anything if all is well. +1. -- Michael signature.asc Description: PGP signature

Re: Verbosity of genbki.pl

2018-04-28 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Peter Eisentraut writes: > > Maybe we can take another look at this. Right now, make -s world > > produces *only* the following output: > > > $ make -s world > > Generating BKI files and symbol definition headers... > > Generating fmgrtab.c, f

Re: Verbosity of genbki.pl

2018-04-28 Thread Tom Lane
Peter Eisentraut writes: > Maybe we can take another look at this. Right now, make -s world > produces *only* the following output: > $ make -s world > Generating BKI files and symbol definition headers... > Generating fmgrtab.c, fmgroids.h, and fmgrprotos.h... > PostgreSQL, contrib, and documen

Re: Verbosity of genbki.pl

2018-04-28 Thread Peter Eisentraut
On 4/9/18 15:02, Tom Lane wrote: > Andres Freund writes: >> On 2018-04-08 13:33:42 -0400, Tom Lane wrote: >>> Traditionally genbki.pl has printed "Writing foo" for every file >>> it writes out. > >>> 2. Print just one message like "Generating postgres.bki and related >>> files", and I guess a sec

Re: Verbosity of genbki.pl

2018-04-09 Thread Tom Lane
Andres Freund writes: > On 2018-04-08 13:33:42 -0400, Tom Lane wrote: >> Traditionally genbki.pl has printed "Writing foo" for every file >> it writes out. >> 2. Print just one message like "Generating postgres.bki and related >> files", and I guess a second one for fmgroids.h and related files.

Re: Verbosity of genbki.pl

2018-04-09 Thread Andres Freund
Hi, On 2018-04-08 13:33:42 -0400, Tom Lane wrote: > Traditionally genbki.pl has printed "Writing foo" for every file > it writes out. > 2. Print just one message like "Generating postgres.bki and related > files", and I guess a second one for fmgroids.h and related files. +0.5. - Andres

Re: Verbosity of genbki.pl

2018-04-09 Thread John Naylor
On 4/9/18, Teodor Sigaev wrote: >> 1. Print nothing at all. That's more in keeping with our modern >> build practices, but maybe it's too big a change? >> >> 2. Print just one message like "Generating postgres.bki and related >> files", and I guess a second one for fmgroids.h and related files. >

Re: Verbosity of genbki.pl

2018-04-08 Thread Teodor Sigaev
1. Print nothing at all. That's more in keeping with our modern build practices, but maybe it's too big a change? 2. Print just one message like "Generating postgres.bki and related files", and I guess a second one for fmgroids.h and related files. I don't have a strong preference. Opinions?

Verbosity of genbki.pl

2018-04-08 Thread Tom Lane
(This was discussed in the "way forward on bootstrap data" thread, but we didn't do anything about it.) Traditionally genbki.pl has printed "Writing foo" for every file it writes out. As of 372728b0d that is a heck of a lot more files than it once was, so you get this: $ make -j8 -s Writing fmgr