On Tue, 5 Nov 2024 at 16:51, hugo <2689496...@qq.com> wrote:
>
> Hi, Kirill
>
> Sorry for the late reply, thanks for your suggestion.
> A simple fix has been added to the attached patch.
>
> --
> hugo
>
Hi! This field is actually used after 14e87ff. Just like Álvaro stated in [0]
Patch status is
On 2024-Nov-05, hugo wrote:
> Hi, Kirill
>
> Sorry for the late reply, thanks for your suggestion.
> A simple fix has been added to the attached patch.
Actually, AFAICT my patch at https://commitfest.postgresql.org/50/5224/
adds a use of this field, so if you remove it, I might have to put it
ba
Hi, Kirill
Sorry for the late reply, thanks for your suggestion.
A simple fix has been added to the attached patch.
--
hugo
v1-0001-Remove-useless-field-ispartitioned-in-CreateStmtC.patch
Description: Binary data
On Thu, 24 Oct 2024 at 18:08, hugo <2689496...@qq.com> wrote:
>
> Hi!
>
>When looking at the partition-related code, I found that the
> ispartitioned
>
> field in CreateStmtContext is not used. It looks like we can safely remove it
> and
>
> avoid invalid assignment logic.
>
>
>
> Here's
Hi
On Thu, 24 Oct 2024, 18:08 hugo, <2689496...@qq.com> wrote:
> Hi!
>
>When looking at the partition-related code, I found that the
> ispartitioned
>
> field in CreateStmtContext is not used. It looks like we can safely remove
> it and
>
> avoid invalid assignment logic.
>
>
>
> Here's a
On Thu, 24 Oct 2024 at 19:23, Alena Rybakina wrote:
>
> Hi!
>
> On 24.10.2024 16:07, hugo wrote:
>
> Hi!
>
>When looking at the partition-related code, I found that the
> ispartitioned
>
> field in CreateStmtContext is not used. It looks like we can safely remove it
> and
>
> avoid inval
Hi!
On 24.10.2024 16:07, hugo wrote:
Hi!
When looking at the partition-related code, I found that the
ispartitioned
field in CreateStmtContext is not used. It looks like we can safely
remove it and
avoid invalid assignment logic.
Here's a very simple fix， any suggestion?
diff --
Hi!
When looking at the partition-related code, I found that the
ispartitioned
field in CreateStmtContext is not used. It looks like we can safely remove it
and
avoid invalid assignment logic.
Here's a very simple fix， any suggestion?
diff --git a/src/backend/parser/parse_utilc
