On Mon, Nov 25, 2024 at 06:25:46PM +0300, Karina Litskevich wrote:
> The patch looks good to me.
Thanks for the review.
> They are not identical: space before AND vs space at the end of the
> previous line. I'd say that it would be better if they were
> identical. Personally, I prefer the one wit
On Sat, Oct 19, 2024 at 4:17 AM Michael Paquier wrote:
> Removed that in the v2 attached.
Hi Michael,
The patch looks good to me.
I'd like to suggest discussing a little cosmetic change in the
affected lines. Compare the following.
Lines 2095-2098:
appendPQExpBuffer(&sql,
"
space after
the RELPERSISTENCE_TEMP bit makes little sense.
Removed that in the v2 attached.
--
Michael
From 7ef323354f1710ee755876132ae719b02c3e0468 Mon Sep 17 00:00:00 2001
From: Michael Paquier
Date: Sat, 19 Oct 2024 10:15:53 +0900
Subject: [PATCH v2] Use more CppAsString2() in pg_amcheck.c
---
On Fri, Oct 18, 2024 at 06:50:50PM +0900, Michael Paquier wrote:
> - appendPQExpBufferStr(&sql, "\nWHERE c.relpersistence != 't'");
> + appendPQExpBufferStr(&sql, "\nWHERE c.relpersistence != "
> +
> CppAsString2(RELPERSISTENCE_TEMP) " ");
I th
On 2024-Oct-18, Alvaro Herrera wrote:
> Hmm, aren't you losing the single quotes?
Ah, the defines themselves include the quotes, so this is not needed.
Sorry for the noise.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Syntax error: function hell() needs an ar
On 2024-Oct-18, Michael Paquier wrote:
> pg_amcheck.c is one of these places where relkind and relpersistence
> values are hardcoded in queries based on the contents of pg_class_d.h.
> Similarly to other places in src/bin/, let's sprinkle some
> CppAsString2() and feed to the binary the values fro
> On 18 Oct 2024, at 11:50, Michael Paquier wrote:
> pg_amcheck.c is one of these places where relkind and relpersistence
> values are hardcoded in queries based on the contents of pg_class_d.h.
> Similarly to other places in src/bin/, let's sprinkle some
> CppAsString2() and feed to the binary t
does that.
Thoughts or comments?
--
Michael
From 9f56c8befb5b59b6c8013c3f7d58d62e5e42c30a Mon Sep 17 00:00:00 2001
From: Michael Paquier
Date: Fri, 18 Oct 2024 18:49:45 +0900
Subject: [PATCH] Use more CppAsString2() in pg_amcheck.c
---
src/bin/pg_amcheck/pg_amcheck.c
