Re: Use PageIndexTupleOverwrite() within nbtsort.c

2019-08-13 Thread Peter Geoghegan
On Tue, Aug 6, 2019 at 8:30 AM Anastasia Lubennikova wrote: > Should we also update similar code in _bt_mark_page_halfdead()? > I attached a new version of the patch with this change. Pushed. At first I thought that there might be a problem with doing the same thing within _bt_mark_page_halfdead

Re: Use PageIndexTupleOverwrite() within nbtsort.c

2019-08-06 Thread Anastasia Lubennikova
16.07.2019 1:12, Peter Geoghegan wrote: Attached patch slightly simplifies nbtsort.c by making it use PageIndexTupleOverwrite() to overwrite the last right non-pivot tuple with the new high key (pivot tuple). PageIndexTupleOverwrite() is designed so that code like this doesn't need to delete and

Use PageIndexTupleOverwrite() within nbtsort.c

2019-07-15 Thread Peter Geoghegan
Attached patch slightly simplifies nbtsort.c by making it use PageIndexTupleOverwrite() to overwrite the last right non-pivot tuple with the new high key (pivot tuple). PageIndexTupleOverwrite() is designed so that code like this doesn't need to delete and re-insert to replace an existing tuple. T