Re: Use PG_FINALLY to simplify code

2020-09-30 Thread Kyotaro Horiguchi
At Tue, 29 Sep 2020 23:10:52 -0400, Tom Lane wrote in tgl> Kyotaro Horiguchi writes: tgl> > At Tue, 29 Sep 2020 01:03:13 +, "Hou, Zhijie" wrote in tgl> >> Since PG_FINALLY can be used now, I think we can use PG_FINALLY to simplify code here. tgl> tgl&

Re: Use PG_FINALLY to simplify code

2020-09-29 Thread Tom Lane
Kyotaro Horiguchi writes: > At Tue, 29 Sep 2020 01:03:13 +, "Hou, Zhijie" > wrote in >> Since PG_FINALLY can be used now, I think we can use PG_FINALLY to simplify >> code here. > The patch removes PG_RETHROW(), which is crucial in the code > path.

Re: Use PG_FINALLY to simplify code

2020-09-29 Thread Kyotaro Horiguchi
xpr->plan = NULL; > PG_RE_THROW(); > } > PG_END_TRY(); > > if (expr->plan && !expr->plan->saved) > expr->plan = NULL; > > Since PG_FINALLY can be used now, I think we can use PG_FINALLY to simplify > code

Use PG_FINALLY to simplify code

2020-09-28 Thread Hou, Zhijie
if (expr->plan && !expr->plan->saved) expr->plan = NULL; Since PG_FINALLY can be used now, I think we can use PG_FINALLY to simplify code here. Best regards, houzj 0001-adjust-code-to-use-PG_FINALLY.patch Description: 0001-adjust-code-to-use-PG_FINALLY.patch