On Mon, Dec 04, 2023 at 09:47:24AM -0800, Andres Freund wrote:
> If we change something, we should consider making buffers like these aligned
> to page sizes, rather than just MAXALIGNED.
You mean 4k kernel pages, right? That makes sense to me.
--
Michael
signature.asc
Description: PGP signatur
Hi,
On 2023-12-04 15:53:44 +0100, Peter Eisentraut wrote:
> On 04.12.23 06:46, Michael Paquier wrote:
> > On Mon, Dec 04, 2023 at 06:59:13AM +0530, Bharath Rupireddy wrote:
> > > The commit 44cac934 replaced "char buf[BLCKSZ]" with PGAlignedBlock to
> > > avoid issues on alignment-picky hardware.
On 04.12.23 06:46, Michael Paquier wrote:
On Mon, Dec 04, 2023 at 06:59:13AM +0530, Bharath Rupireddy wrote:
The commit 44cac934 replaced "char buf[BLCKSZ]" with PGAlignedBlock to
avoid issues on alignment-picky hardware. While it replaced most of the
instances, there are still some more left. H
On Mon, Dec 04, 2023 at 06:59:13AM +0530, Bharath Rupireddy wrote:
> The commit 44cac934 replaced "char buf[BLCKSZ]" with PGAlignedBlock to
> avoid issues on alignment-picky hardware. While it replaced most of the
> instances, there are still some more left. How about we use PGAlignedBlock
> there
3 Dec 2023 09:33:37 +0000
Subject: [PATCH v1] Use PGAlignedBlock instead of "char buf[BLCKSZ]" in more
places
Commit 44cac934 replaced "char buf[BLCKSZ]" with PGAlignedBlock to
avoid issues on alignment-picky hardware. While it replaced most
of the instances, there are still some more le