Re: Update LDAP Protocol in fe-connect.c to v3

2025-05-23 Thread Peter Eisentraut
On 15.05.25 14:54, Pavel Seleznev wrote: I applied your patch. I ran extended application tests relative to vanilla ones, which include various scenarios of working with LDAP and I think that we can safely apply the patch in the PG18. I did not see the need for additional LDAP tests, since com

Re: Update LDAP Protocol in fe-connect.c to v3

2025-05-15 Thread Pavel Seleznev
I applied your patch. I ran extended application tests relative to vanilla ones, which include various scenarios of working with LDAP and I think that we can safely apply the patch in the PG18. I did not see the need for additional LDAP tests, since compatibility is provided by the LDAP library

Re: Update LDAP Protocol in fe-connect.c to v3

2025-04-05 Thread Andrew Jackson
Apologies, forgot to attach the patch in the prior email. On Sat, Mar 22, 2025 at 4:10 PM Andrew Jackson wrote: > Currently the LDAP usage in fe-connect.c does not explicitly set the > protocol version to v3. This causes issues with many LDAP servers as they > will often require clients to use t

Re: Update LDAP Protocol in fe-connect.c to v3

2025-04-04 Thread Andrew Jackson
Hi, Added some tests for the LDAP connection parameters lookup functionality with the attached patch. It is based off of the tests that were added recently that cover the connection service file libpq functionality as well as the existing ldap test framework. Thanks, Andrew Jackson On Wed, Mar 2

Re: Update LDAP Protocol in fe-connect.c to v3

2025-04-04 Thread Andrew Jackson
Here is the same patch as v2 but with "const" removed in case you want to move forward with that change. Tested locally against the tests I wrote in the other patch to sanity check the change. On Thu, Apr 3, 2025 at 8:42 AM Tom Lane wrote: > Peter Eisentraut writes: > > Here is a slightly polis

Re: Update LDAP Protocol in fe-connect.c to v3

2025-04-03 Thread Tom Lane
Peter Eisentraut writes: > Here is a slightly polished version of this patch. I added an error > message, and changed the return code, but it's a bit confusing which one > might be the right one. I'm kind of -0.5 on declaring the variable as "const", because none of our existing calls of ldap_

Re: Update LDAP Protocol in fe-connect.c to v3

2025-04-03 Thread Peter Eisentraut
On 22.03.25 22:22, Andrew Jackson wrote: Apologies, forgot to attach the patch in the prior email. On Sat, Mar 22, 2025 at 4:10 PM Andrew Jackson mailto:andrewjackson...@gmail.com>> wrote: Currently the LDAP usage in fe-connect.c does not explicitly set the protocol version to v3. Thi

Re: Update LDAP Protocol in fe-connect.c to v3

2025-03-25 Thread Peter Eisentraut
On 23.03.25 04:05, Andrew Jackson wrote: > This is the first complaint I can recall hearing about that, so exactly which ones are "many"? I've tested a 2 before figuring out about the v3 issue. lldap[0] and the docker image osixia/docker-openldap[1]. - lldap  gives the following error message

Re: Update LDAP Protocol in fe-connect.c to v3

2025-03-22 Thread Andrew Jackson
> This is the first complaint I can recall hearing about that, so exactly which ones are "many"? I've tested a 2 before figuring out about the v3 issue. lldap[0] and the docker image osixia/docker-openldap[1]. - lldap gives the following error message when I attempt to connect without the patch "

Re: Update LDAP Protocol in fe-connect.c to v3

2025-03-22 Thread Tom Lane
Andrew Jackson writes: > Currently the LDAP usage in fe-connect.c does not explicitly set the > protocol version to v3. This causes issues with many LDAP servers as they > will often require clients to use the v3 protocol and disallow any use of > the v2 protocol. This is the first complaint I ca

Update LDAP Protocol in fe-connect.c to v3

2025-03-22 Thread Andrew Jackson
Currently the LDAP usage in fe-connect.c does not explicitly set the protocol version to v3. This causes issues with many LDAP servers as they will often require clients to use the v3 protocol and disallow any use of the v2 protocol. Further the other usage of LDAP in postgres (in `backend/libpq/au