Zhihong Yu writes:
> Andrew:
> Can you let me know which thread you were referring to?
I assume he meant
https://www.postgresql.org/message-id/flat/31e2e921-7002-4c27-59f5-51f08404c858%402ndQuadrant.com
whih was last added to just moments ago.
regards, tom lane
I found the recent thread under 'ALTER TABLE ADD COLUMN fast default' which
hasn't appeared in the message chain yet.
I will watch that thread.
Cheers
On Sun, Apr 4, 2021 at 8:47 AM Zhihong Yu wrote:
> Andrew:
> Can you let me know which thread you were referring to?
>
> I navigated the thre
Andrew:
Can you let me know which thread you were referring to?
I navigated the thread mentioned in your commit. It has been more than 3
years since the last response:
https://www.postgresql.org/message-id/CAA8%3DA7-OPsGeazXxiojQNMus51odNZVn8EVNSoWZ2y9yRL%2BBvQ%40mail.gmail.com
Can you let me kn
On 4/4/21 9:39 AM, Zhihong Yu wrote:
> Andrew:
> Can you chime in which direction to go ?
>
> Once consensus is reached, I can provide a new patch, if needed.
>
> Cheers
>
>
[ please don't top-post ]
I don't think we need a new patch. We'll clean this up one way or
another as part of the clean
Andrew:
Can you chime in which direction to go ?
Once consensus is reached, I can provide a new patch, if needed.
Cheers
On Sat, Apr 3, 2021 at 9:54 PM Michael Paquier wrote:
> On Sun, Apr 04, 2021 at 10:13:26AM +0530, Bharath Rupireddy wrote:
> > +1 to remove it and the patch LGTM.
>
> Indeed
Michael Paquier writes:
> On Sun, Apr 04, 2021 at 10:13:26AM +0530, Bharath Rupireddy wrote:
>> +1 to remove it and the patch LGTM.
> Indeed, there is no point to keep that around. I'll go clean up that
> as you propose.
What Andrew was suggesting in the other thread might well result in
puttin
On Sun, Apr 04, 2021 at 10:13:26AM +0530, Bharath Rupireddy wrote:
> +1 to remove it and the patch LGTM.
Indeed, there is no point to keep that around. I'll go clean up that
as you propose.
--
Michael
signature.asc
Description: PGP signature
On Sun, Apr 4, 2021 at 8:14 AM Zhihong Yu wrote:
>
> Hi,
> I was looking at AttrDefaultFetch and saw that the variable found is never
> read.
>
> I think it can be removed. See attached patch.
+1 to remove it and the patch LGTM. For reference, below is the commit
that removed last usage of "foun
Hi,
I was looking at AttrDefaultFetch and saw that the variable found is never
read.
I think it can be removed. See attached patch.
Cheers
def-fetch-found.patch
Description: Binary data
