Re: Unused stricture field in xlogreader:DecodedBkpBlock

2025-10-17 Thread Masahiko Sawada
On Fri, Oct 17, 2025 at 11:22 AM Masahiko Sawada wrote: > > On Fri, Oct 17, 2025 at 5:06 AM Nazir Bilal Yavuz wrote: > > > > Hi, > > > > On Fri, 17 Oct 2025 at 14:37, Mikhail Gribkov wrote: > > > > > > Hi hackers, > > > > > > I found that DecodedBkpBlock.data_bufsz field in xlogreader.h is never

Re: Unused stricture field in xlogreader:DecodedBkpBlock

2025-10-17 Thread Masahiko Sawada
On Fri, Oct 17, 2025 at 5:06 AM Nazir Bilal Yavuz wrote: > > Hi, > > On Fri, 17 Oct 2025 at 14:37, Mikhail Gribkov wrote: > > > > Hi hackers, > > > > I found that DecodedBkpBlock.data_bufsz field in xlogreader.h is never ever > > used in the current code and not even mentioned in any comments. I

Re: Unused stricture field in xlogreader:DecodedBkpBlock

2025-10-17 Thread Nazir Bilal Yavuz
Hi, On Fri, 17 Oct 2025 at 14:37, Mikhail Gribkov wrote: > > Hi hackers, > > I found that DecodedBkpBlock.data_bufsz field in xlogreader.h is never ever > used in the current code and not even mentioned in any comments. It just > occupies memory and removing it doesn't seem to break anything. >

Unused stricture field in xlogreader:DecodedBkpBlock

2025-10-17 Thread Mikhail Gribkov
Hi hackers, I found that DecodedBkpBlock.data_bufsz field in xlogreader.h is never ever used in the current code and not even mentioned in any comments. It just occupies memory and removing it doesn't seem to break anything. Should we remove it maybe? Attached is the removal patch. -- best regard