On Wed, Feb 12, 2025 at 03:47:14PM -0600, Nathan Bossart wrote:
> On Wed, Feb 12, 2025 at 09:38:04AM -0600, Nathan Bossart wrote:
> > In any case, I don't see a problem with removing "volatile" now, so I'll
> > plan on committing this later today if there are no objections.
>
> Committed.
Thanks.
On Wed, Feb 12, 2025 at 09:38:04AM -0600, Nathan Bossart wrote:
> In any case, I don't see a problem with removing "volatile" now, so I'll
> plan on committing this later today if there are no objections.
Committed.
--
nathan
On Wed, Feb 12, 2025 at 08:41:34AM +, Bertrand Drouvot wrote:
> On Wed, Feb 12, 2025 at 04:25:38PM +0800, Julien Rouhaud wrote:
>> While reading some code in fmgr.c I noticed that the save_nestlevel variable
>> is
>> declared as volatile. I'm assuming that's because a long time ago it was
>>
Hi,
On Wed, Feb 12, 2025 at 04:25:38PM +0800, Julien Rouhaud wrote:
> Hi,
>
> While reading some code in fmgr.c I noticed that the save_nestlevel variable
> is
> declared as volatile. I'm assuming that's because a long time ago it was
> modified in the PG_TRY / PG_CATCH block but it doesn't loo
Hi,
While reading some code in fmgr.c I noticed that the save_nestlevel variable is
declared as volatile. I'm assuming that's because a long time ago it was
modified in the PG_TRY / PG_CATCH block but it doesn't look needed anymore.
Trivial patch attached.
diff --git a/src/backend/utils/fmgr/fmg
