Re: Unicode normalization test broken output

2019-12-10 Thread Peter Eisentraut
On 2019-12-10 17:16, Tom Lane wrote: Peter Eisentraut writes: Good point. Fixed in attached patch. This one LGTM. done, thanks -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Unicode normalization test broken output

2019-12-10 Thread Tom Lane
Peter Eisentraut writes: > Good point. Fixed in attached patch. This one LGTM. regards, tom lane

Re: Unicode normalization test broken output

2019-12-10 Thread Peter Eisentraut
On 2019-12-09 23:22, Tom Lane wrote: Peter Eisentraut writes: There appear to be several off-by-more-than-one errors in norm_test.c print_wchar_str(). Attached is a patch to fix this (and make the output a bit prettier). Result afterwards: I concur that this looks broken and your patch impr

Re: Unicode normalization test broken output

2019-12-09 Thread Tom Lane
Peter Eisentraut writes: > There appear to be several off-by-more-than-one errors in norm_test.c > print_wchar_str(). Attached is a patch to fix this (and make the output > a bit prettier). Result afterwards: I concur that this looks broken and your patch improves it. But I'm not very happy a

Unicode normalization test broken output

2019-12-09 Thread Peter Eisentraut
I was playing with the Unicode normalization test in src/common/unicode/. I think there is something wrong with how the test program reports failures. For example, if I manually edit the norm_test_table.h to make a failure, like -{ 74, { 0x00A8, 0 }, { 0x0020, 0x0308, 0 } }, +{ 74, {