Re: Unable parse a comment in gram.y

2024-06-23 Thread Tatsuo Ishii
>>> +1. It's easier to understand at least for me. > >> +1 > > OK. I looked through the rest of src/backend/parser/ and couldn't > find any other similar wording. There's plenty of "As with ..." > and "As in ...", but at least to me those don't seem confusing. > I'll plan to push the attached a

Re: Unable parse a comment in gram.y

2024-06-23 Thread Tom Lane
"David G. Johnston" writes: > On Saturday, June 22, 2024, Tatsuo Ishii wrote: >>> Perhaps s/As func_expr/Like func_expr/ would be less confusing? >> +1. It's easier to understand at least for me. > +1 OK. I looked through the rest of src/backend/parser/ and couldn't find any other similar wor

Re: Unable parse a comment in gram.y

2024-06-22 Thread David G. Johnston
On Saturday, June 22, 2024, Tatsuo Ishii wrote: > >>> * As func_expr but does not accept WINDOW functions directly (they > >>> * can still be contained in arguments for functions etc.) > > > >> The "but" is required, add a comma before it. It could also be written > a > >> bit more verbosely: >

Re: Unable parse a comment in gram.y

2024-06-22 Thread Tatsuo Ishii
>>> * As func_expr but does not accept WINDOW functions directly (they >>> * can still be contained in arguments for functions etc.) > >> The "but" is required, add a comma before it. It could also be written a >> bit more verbosely: > > Perhaps s/As func_expr/Like func_expr/ would be less confu

Re: Unable parse a comment in gram.y

2024-06-22 Thread Tom Lane
"David G. Johnston" writes: > On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii wrote: >> I was unable to parse a comment in src/backend/parser/gram.y around line >> 11364: >> >> * As func_expr but does not accept WINDOW functions directly (they >> * can still be contained in arguments for functions

Re: Unable parse a comment in gram.y

2024-06-22 Thread Tatsuo Ishii
> On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii wrote: > >> I was unable to parse a comment in src/backend/parser/gram.y around line >> 11364: >> >> /* >> * As func_expr but does not accept WINDOW functions directly (they >> * can still be contained in arguments for functions etc.) >> * Use thi

Re: Unable parse a comment in gram.y

2024-06-22 Thread David G. Johnston
On Sat, Jun 22, 2024 at 9:02 PM Tatsuo Ishii wrote: > I was unable to parse a comment in src/backend/parser/gram.y around line > 11364: > > /* > * As func_expr but does not accept WINDOW functions directly (they > * can still be contained in arguments for functions etc.) > * Use this when wind

Unable parse a comment in gram.y

2024-06-22 Thread Tatsuo Ishii
I was unable to parse a comment in src/backend/parser/gram.y around line 11364: /* * As func_expr but does not accept WINDOW functions directly (they * can still be contained in arguments for functions etc.) * Use this when window expressions are not allowed, so to disambiguate * the grammar.