Re: Ubsan complaint on kestrel

2025-03-03 Thread Tom Lane
Andres Freund writes: > ../../../../../home/andres/src/postgresql/src/backend/nodes/nodeFuncs.c:2712:6: > runtime error: call to function assign_query_collations_walker through > pointer to incorrect function type 'bool (*)(struct Node *, void *)' > /srv/dev/build/postgres/m-dev-assert-clang-san

Re: Ubsan complaint on kestrel

2025-03-03 Thread Andres Freund
Hi, On 2025-03-03 16:49:09 -0500, Tom Lane wrote: > Andres Freund writes: > > I wish the sanitizer treated mismatches of void * arguments against a "real > > type" different from other mismatches, but ... > > Indeed. I think we have enough coverage of that via compile-time > checks, though -- i

Re: Ubsan complaint on kestrel

2025-03-03 Thread Andres Freund
Hi, On 2025-03-03 15:00:43 -0500, Tom Lane wrote: > Andres Freund writes: > > I just upgraded buildfarm animal kestrel (a buildfarm animal running with > > ubsan) to a newer version of clang. Unfortunately this causes it to fail. > > ... > > Tom, do you see any reason to not instead do the typec

Re: Ubsan complaint on kestrel

2025-03-03 Thread Tom Lane
Andres Freund writes: > I just upgraded buildfarm animal kestrel (a buildfarm animal running with > ubsan) to a newer version of clang. Unfortunately this causes it to fail. > ... > Tom, do you see any reason to not instead do the typecase inside > string_compare()? No. Have at it.

Ubsan complaint on kestrel

2025-03-03 Thread Andres Freund
Hi, I just upgraded buildfarm animal kestrel (a buildfarm animal running with ubsan) to a newer version of clang. Unfortunately this causes it to fail. The buildfarm output doesn't contain enough information to debug that unfortunately. But I triggered it manually and meson-logs/testlog.txt did