Re: Typo in pg_stat_activity definition

2025-06-30 Thread Michael Paquier
On Mon, Jun 30, 2025 at 04:03:01PM +0900, Daisuke Higuchi wrote: > Yes, applying this patch will not cause the 'rules' test to fail. > Even if the pg_stat_activity view definition information in > system_views.sql is capitalized (inconsistency is fixed) by this patch, it > will be lowercase when th

Re: Typo in pg_stat_activity definition

2025-06-30 Thread Daisuke Higuchi
Thank you for comments! >> One thing that you are forgetting is that the regression >> tests are going to fail: rules.out reports the definition of >> pg_stat_activity, and the characters casing matters in this case. > >I doubt it --- the regression tests will show deparsing results, >which shoul

Typo in pg_stat_activity definition

2025-06-29 Thread Daisuke Higuchi
I noticed an inconsistency between uppercase and lowercase letters in only one place of pg_stat_activity definition, so I'll report it. I think this is just a typo and there is no functionality issue. When I compared to the content before and after, I think the capital letter "S" than "s" is suitab

Re: Typo in pg_stat_activity definition

2025-06-29 Thread Tom Lane
Michael Paquier writes: > On Mon, Jun 30, 2025 at 01:44:58PM +0900, Daisuke Higuchi wrote: >> When I compared to the content before and after, I think the capital letter >> "S" than "s" is suitable for alias, as shown below. > Yeah, makes sense to me to fix this inconsistency on HEAD, even if > i

Re: Typo in pg_stat_activity definition

2025-06-29 Thread Michael Paquier
On Mon, Jun 30, 2025 at 01:44:58PM +0900, Daisuke Higuchi wrote: > I noticed an inconsistency between uppercase and lowercase letters in only > one place of pg_stat_activity definition, so I'll report it. I think this > is just a typo and there is no functionality issue. > When I compared to the co