On Sun, Nov 13, 2022 at 8:32 PM Japin Li wrote:
>
> On Sat, 12 Nov 2022 at 12:12, Amit Kapila wrote:
> >
> > I don't know if that is an improvement. I think we should stick to
> > your initial proposed change.
>
> Agreed. Let's focus on the initial proposed change.
>
Pushed.
--
With Regards,
On Sat, 12 Nov 2022 at 12:12, Amit Kapila wrote:
> On Fri, Nov 11, 2022 at 2:45 PM Japin Li wrote:
>> Maybe a wrong plural in XidInMvccSnapshot().
>>
>> * Make a quick range check to eliminate most XIDs without looking at the
>> * xip arrays.
>>
>> I think we should use "xip array" in
On Fri, Nov 11, 2022 at 2:45 PM Japin Li wrote:
>
> On Fri, 11 Nov 2022 at 15:23, Amit Kapila wrote:
> > On Fri, Nov 11, 2022 at 12:16 PM Richard Guo wrote:
> >>
> >> On Fri, Nov 11, 2022 at 11:26 AM Japin Li wrote:
> >>>
> >>> Recently, when I read the XidInMVCCSnapshot(), and find there are s
On Fri, 11 Nov 2022 at 15:23, Amit Kapila wrote:
> On Fri, Nov 11, 2022 at 12:16 PM Richard Guo wrote:
>>
>> On Fri, Nov 11, 2022 at 11:26 AM Japin Li wrote:
>>>
>>> Recently, when I read the XidInMVCCSnapshot(), and find there are some
>>> typos in the comments.
>>
>>
>> Hmm, it seems to me '
On Fri, Nov 11, 2022 at 12:16 PM Richard Guo wrote:
>
> On Fri, Nov 11, 2022 at 11:26 AM Japin Li wrote:
>>
>> Recently, when I read the XidInMVCCSnapshot(), and find there are some
>> typos in the comments.
>
>
> Hmm, it seems to me 'the subxact array' is just another saying to refer
> to snapsh
On Fri, Nov 11, 2022 at 11:26 AM Japin Li wrote:
> Recently, when I read the XidInMVCCSnapshot(), and find there are some
> typos in the comments.
Hmm, it seems to me 'the subxact array' is just another saying to refer
to snapshot->subxip. I'm not sure about this being typo. But I have no
obj
On Fri, Nov 11, 2022 at 10:39:06AM +0530, Amit Kapila wrote:
> On Fri, Nov 11, 2022 at 8:56 AM Japin Li wrote:
> >
> > Recently, when I read the XidInMVCCSnapshot(), and find there are some
> > typos in the comments.
> >
> > diff --git a/src/backend/storage/ipc/procarray.c
> > b/src/backend/stora
On Fri, Nov 11, 2022 at 8:56 AM Japin Li wrote:
>
> Recently, when I read the XidInMVCCSnapshot(), and find there are some
> typos in the comments.
>
> diff --git a/src/backend/storage/ipc/procarray.c
> b/src/backend/storage/ipc/procarray.c
> index 207c4b27fd..9e8b6756fe 100644
> --- a/src/backen
Hi, hackers
Recently, when I read the XidInMVCCSnapshot(), and find there are some
typos in the comments.
diff --git a/src/backend/storage/ipc/procarray.c
b/src/backend/storage/ipc/procarray.c
index 207c4b27fd..9e8b6756fe 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/stora
