Hi,
On 2018-10-02 17:28:26 +0900, Amit Langote wrote:
> On 2018/10/02 16:40, Andres Freund wrote:
> > I'm kinda wondering if we shouldn't have the tuple
> > conversion functions just use the slot based functionality in the back,
> > and just store those in the TupConversionMap.
>
> Sorry, I didn'
On 2018/10/02 16:40, Andres Freund wrote:
>>> For executing them we have:
>>> - do_convert_tuple
>>> - ConvertPartitionTupleSlot
>>>
>>> which is two randomly differing spellings of related functionality,
>>> without the name indicating that they, for reasons, don't both use
>>> TupleConversionMap.
Hi,
On 2018-10-02 16:18:19 +0900, Amit Langote wrote:
> Hi,
>
> I agree that some clean up might be in order, but want to clarify a few
> points.
>
> On 2018/10/02 15:11, Andres Freund wrote:
> > Hi,
> >
> > The naming around partition related tuple conversions is imo worthy of
> > improvement.
Hi,
I agree that some clean up might be in order, but want to clarify a few
points.
On 2018/10/02 15:11, Andres Freund wrote:
> Hi,
>
> The naming around partition related tuple conversions is imo worthy of
> improvement.
Note that tuple conversion functionality in tupconvert.c has existed even
Hi,
The naming around partition related tuple conversions is imo worthy of
improvement.
For building tuple conversion maps we have:
- convert_tuples_by_name
- convert_tuples_by_name_map
- convert_tuples_by_position
- ExecSetupChildParentMapForLeaf
- TupConvMapForLeaf
- free_conversion_map
I've a
