On Wed, Apr 21, 2021 at 09:46:59AM +0800, Julien Rouhaud wrote:
> +1, it looks good to me.
Cool, thanks for confirming. The top of the docs have IMO enough
details about the requirements around compute_query_id and third-part
modules, so we are done here.
--
Michael
signature.asc
Description: P
On Wed, Apr 21, 2021 at 10:27:43AM +0900, Michael Paquier wrote:
> On Wed, Apr 21, 2021 at 11:10:36AM +1000, Greg Nancarrow wrote:
> > However, I don't think the additional comment is really warranted
> > here, as the other typical usage settings are not commented, and all
> > settings are explaine
On Wed, Apr 21, 2021 at 6:40 AM Greg Nancarrow wrote:
>
> On Tue, Apr 20, 2021 at 8:06 PM Bharath Rupireddy
> wrote:
> > > I've attached a patch for this.
> >
> > +1. How about mentioning something like below?
> >
> > +compute_query_id = on # when in-core query identifier computation is
> > desir
On Wed, Apr 21, 2021 at 11:10:36AM +1000, Greg Nancarrow wrote:
> However, I don't think the additional comment is really warranted
> here, as the other typical usage settings are not commented, and all
> settings are explained in the surrounding documentation.
Good catch, Greg. I agree to keep t
On Tue, Apr 20, 2021 at 8:06 PM Bharath Rupireddy
wrote:
> > I've attached a patch for this.
>
> +1. How about mentioning something like below?
>
> +compute_query_id = on # when in-core query identifier computation is
> desired, otherwise off.
>
Hmm, I think that comment is perhaps slightly misle
On Tue, Apr 20, 2021 at 3:19 PM Greg Nancarrow wrote:
>
> Hi,
>
> I noticed that the pg_stat_statements documentation doesn't include
> the necessary config parameter setting "compute_query_id = on" in the
> "typical usage" (so if you just used those existing typical usage
> settings, the tracking
Hi,
I noticed that the pg_stat_statements documentation doesn't include
the necessary config parameter setting "compute_query_id = on" in the
"typical usage" (so if you just used those existing typical usage
settings, the tracking wouldn't actually work).
I've attached a patch for this.
Regards,
