Re: Timing of relcache inval at parallel worker init

2020-10-24 Thread Noah Misch
On Wed, Oct 21, 2020 at 11:31:54AM -0400, Robert Haas wrote: > On Sat, Oct 17, 2020 at 7:53 AM Noah Misch wrote: > > Let's move InvalidateSystemCaches() later. > > Invalidation should follow any worker initialization step that changes the > > results of relcache validation; otherwise, we'd need to

Re: Timing of relcache inval at parallel worker init

2020-10-21 Thread Robert Haas
On Sat, Oct 17, 2020 at 7:53 AM Noah Misch wrote: > Let's move InvalidateSystemCaches() later. > Invalidation should follow any worker initialization step that changes the > results of relcache validation; otherwise, we'd need to ensure the > InvalidateSystemCaches() will not validate any relcache

Re: Timing of relcache inval at parallel worker init

2020-10-20 Thread Kyotaro Horiguchi
At Sat, 17 Oct 2020 04:53:06 -0700, Noah Misch wrote in > While reviewing what became commit fe4d022, I was surprised at the sequence of > relfilenode values that RelationInitPhysicalAddr() computed for pg_class, > during ParallelWorkerMain(), when running the last command of this recipe: > >

Timing of relcache inval at parallel worker init

2020-10-17 Thread Noah Misch
While reviewing what became commit fe4d022, I was surprised at the sequence of relfilenode values that RelationInitPhysicalAddr() computed for pg_class, during ParallelWorkerMain(), when running the last command of this recipe: begin; cluster pg_class using pg_class_oid_index; set force_para