Re: Three commit tips

2023-11-02 Thread Alexander Lakhin
02.11.2023 18:22, Bruce Momjian wrote: Third, I have come up with the following shell script to test for proper pgindentation, which I run automatically before commit: I would also suggest using a script like attached to check a patch for new unicums (usually some of them are typos or inconsist

Re: Three commit tips

2023-11-02 Thread Ashutosh Bapat
On Thu, Nov 2, 2023 at 8:52 PM Bruce Momjian wrote: > > Third, I have come up with the following shell script to test for proper > pgindentation, which I run automatically before commit: > > # > https://www.postgresql.org/message-id/CAGECzQQL-Dbb%2BYkid9Dhq-491MawHvi6hR_NGkhiDE%2B5zRZ6vQ%

Re: Three commit tips

2023-11-02 Thread Bruce Momjian
On Thu, Nov 2, 2023 at 11:07:19AM -0500, Nathan Bossart wrote: > On Thu, Nov 02, 2023 at 11:22:38AM -0400, Bruce Momjian wrote: > > First, I have been hesitant to ascribe others as patch authors if I > > heavily modified a doc patch because I didn't want them blamed for any > > mistakes I made. H

Re: Three commit tips

2023-11-02 Thread Nathan Bossart
On Thu, Nov 02, 2023 at 11:22:38AM -0400, Bruce Momjian wrote: > First, I have been hesitant to ascribe others as patch authors if I > heavily modified a doc patch because I didn't want them blamed for any > mistakes I made. However, I also want to give them credit, so I decided > I would annotate

Three commit tips

2023-11-02 Thread Bruce Momjian
I have three suggestions on committing that I thought would be helpful to the hacker audience. First, I have been hesitant to ascribe others as patch authors if I heavily modified a doc patch because I didn't want them blamed for any mistakes I made. However, I also want to give them credit, so I