Re: Thread-unsafe MD5 on big-endian systems with no OpenSSL

2024-08-07 Thread Heikki Linnakangas
On 06/08/2024 18:11, Michael Paquier wrote: On Aug 6, 2024, at 23:05, Robert Haas wrote: On Tue, Aug 6, 2024 at 8:23 AM Heikki Linnakangas wrote: This only affects big-endian systems that are compiled without OpenSSL. LGTM. Nice catch, looks fine to me as well. Committed, thanks --

Re: Thread-unsafe MD5 on big-endian systems with no OpenSSL

2024-08-06 Thread Michael Paquier
> On Aug 6, 2024, at 23:05, Robert Haas wrote: > On Tue, Aug 6, 2024 at 8:23 AM Heikki Linnakangas wrote: >> >> This only affects big-endian systems that are compiled without OpenSSL. > > LGTM. Nice catch, looks fine to me as well. -- Michael

Re: Thread-unsafe MD5 on big-endian systems with no OpenSSL

2024-08-06 Thread Robert Haas
On Tue, Aug 6, 2024 at 8:23 AM Heikki Linnakangas wrote: > While browsing through all our global variables for the multithreading > effort, I noticed that our MD5 implementation in src/common/md5.c uses a > static buffer on big-endian systems, which makes it not thread-safe. > That's a bug because

Thread-unsafe MD5 on big-endian systems with no OpenSSL

2024-08-06 Thread Heikki Linnakangas
While browsing through all our global variables for the multithreading effort, I noticed that our MD5 implementation in src/common/md5.c uses a static buffer on big-endian systems, which makes it not thread-safe. That's a bug because that function is also used in libpq. This was introduced in