Re: The same 2PC data maybe recovered twice

2025-07-14 Thread suyu.cmj
> Actually, what you are doing is incorrect because we could miss some > ERRORs for example if a base backup was incorrect if come files were > present in pg_twophase? Yes, you are right, base backup with incorrect files would be a problem. > It's not really true that what you are changing here has

Re: The same 2PC data maybe recovered twice

2025-07-14 Thread Michael Paquier
On Mon, Jul 14, 2025 at 02:46:25PM +0800, CAI, Mengjuan wrote: > Thank you for your reply. I reviewed the thread you mentioned, and > it seems that the issue needing to be fixed is not the same as the > one I previously raised. > I am considering whether the 2PC file check logic in > PrepareRedoAdd

Re: The same 2PC data maybe recovered twice

2025-07-13 Thread CAI, Mengjuan
Hi Michael, Thank you for your reply. I reviewed the thread you mentioned, and it seems that the issue needing to be fixed is not the same as the one I previously raised. I am considering whether the 2PC file check logic in PrepareRedoAdd() can be modified. Currently, each time a XLOG_XACT_PREPA

Re: The same 2PC data maybe recovered twice

2023-07-12 Thread Andy Fan
he method a). Any suggestion is welcome. > > -- > 发件人:蔡梦娟(玊于) > 发送时间:2023年7月6日(星期四) 10:02 > 收件人:pgsql-hackers > 抄 送:pgsql-bugs > 主 题:The same 2PC data maybe recovered twice > > Hi, all. I want to report a bug about recovery of 2pc data, in current > im