Re: TestForOldSnapshot() seems to be in the wrong place

2019-01-22 Thread Kevin Grittner
On Fri, Jan 18, 2019 at 3:13 PM Andres Freund wrote: > TestForOldSnapshot() > to me it seems wrong from a layering POV to have this in > bufmgr.[ch]. Due to the inline functions this makes bufmgr.h have a > dependency on snapmgr.h and tqual.h, which to me seems wrong from a > layer POV. Why isn

TestForOldSnapshot() seems to be in the wrong place

2019-01-18 Thread Andres Freund
Hi, Currently TestForOldSnapshot() is defined as extern void TestForOldSnapshot_impl(Snapshot snapshot, Relation relation); ... /* * Check whether the given snapshot is too old to have safely read the given * page from the given table. If so, throw a "snapshot too old" error. * * This test