Re: Test harness for regex code (to allow importing Tcl's test suite)

2021-01-17 Thread Tom Lane
Alexander Lakhin writes: > select * from test_regex(repeat('(x)', 32), 'a', 'c'); > leads to > ==00:00:00:05.736 2605072== Invalid write of size 4 Indeed, silly oversight on my part. Fixed, thanks! regards, tom lane

Re: Test harness for regex code (to allow importing Tcl's test suite)

2021-01-16 Thread Alexander Lakhin
Hello Tom, 04.01.2021 08:47, Tom Lane wrote: > Hm. There isn't anything about test_regex()'s API that I would want > to expose to end users ;-) ... it's just designed to replicate the > test API that Henry Spencer designed a couple decades ago, which IMO > was not too clean even by the standards o

Re: Test harness for regex code (to allow importing Tcl's test suite)

2021-01-04 Thread Joel Jacobson
On Mon, Jan 4, 2021, at 04:49, Tom Lane wrote: >Over the holiday break I've been fooling with some regex performance >improvements. Cool! I've also been fooling with regex performance over the years myself, not in the PostgreSQL code, but in general. More specifically, to first DFA-minimize the

Re: Test harness for regex code (to allow importing Tcl's test suite)

2021-01-03 Thread Tom Lane
Mark Dilger writes: > Have you thought about whether If it weren't in test/modules, it might be > nice to expose test_regex from SQL with a slightly different interface that > doesn't throw on regex compilation error? Maybe something in contrib? It > might be useful to some users to validate

Re: Test harness for regex code (to allow importing Tcl's test suite)

2021-01-03 Thread Mark Dilger
> On Jan 3, 2021, at 7:49 PM, Tom Lane wrote: > > Over the holiday break I've been fooling with some regex performance > improvements. I don't have anything ready to show yet in that line, > but I was feeling the need for more-thorough test coverage, so I set > to work on something that's bee