On Thu, 5 Sept 2024 at 04:59, Michael Paquier wrote:
> Even if the code is compiled with injection points enabled, it's still
> going to be necessary to check if the module exists in the
> installation or not. And it may or may not be around.
>
OK, thanks for an explanation, I get it.
--
Best
On Wed, Sep 04, 2024 at 07:05:32PM +0300, Maxim Orlov wrote:
> Works for me with configure build. Meson build, obviously, still need extra
> "meson compile install-test-files" step
> as expected. From your patch, I see that you used safe_psql call to check
> for availability of the injection_points
On Wed, 4 Sept 2024 at 03:40, Michael Paquier wrote:
> Any thoughts about the attached? This makes installcheck work here
> with and without the configure switch.
>
>
Works for me with configure build. Meson build, obviously, still need extra
"meson compile install-test-files" step
as expected.
On Mon, Sep 02, 2024 at 09:53:30AM +0900, Michael Paquier wrote:
> REL_17_STABLE is frozen for a few more days, so I'll address all the
> items of this thread that once the release of this week is tagged: the
> export duplicates and the installcheck issue. These are staged on a
> local branch for
On Fri, Aug 23, 2024 at 06:45:02PM -0400, Tom Lane wrote:
> It exports it twice, though, which is pretty confusing.
Right. I am not sure what was my state of mind back then, but this
pattern has spread a bit.
REL_17_STABLE is frozen for a few more days, so I'll address all the
items of this thre
By the way, we have the same kind of "problem" with the meson build. As we
are deliberately
not want to install src/test/modules, after b6a0d469cae and 0d237aeebaee we
must add step
"meson compile install-test-files" in order to "meson test -q --setup
running" to be successful.
To be honest, this
Alvaro Herrera writes:
> On 2024-Aug-23, Michael Paquier wrote:
>>> I've been curious about what exactly does this Makefile line
>>> export enable_injection_points enable_injection_points
>>> achieve.
>> Without this line, the TAP tests would not be able to know if
>> injection points are enabled
On 2024-Aug-23, Michael Paquier wrote:
> On Tue, Aug 20, 2024 at 12:30:35PM -0400, Alvaro Herrera wrote:
> > Yeah, I like this option. Injection points require to be explicitly
> > enabled in configure, so skipping that test when injection_points can't
> > be found seems reasonable.
>
> My apolo
On Tue, Aug 20, 2024 at 12:30:35PM -0400, Alvaro Herrera wrote:
> Yeah, I like this option. Injection points require to be explicitly
> enabled in configure, so skipping that test when injection_points can't
> be found seems reasonable.
My apologies for the delay in doing something here.
The sim
On Tue, Aug 20, 2024 at 12:10:08PM -0400, Tom Lane wrote:
> ... which would also imply writing documentation and so forth,
> and it'd mean that injection_points starts to show up in end-user
> installations. (That would happen with the alternative choice of
> hacking install-world to include src/t
On 2024-Aug-20, Tom Lane wrote:
> We do, however, need to preserve the property that installcheck
> works after install-world. I'm starting to think that maybe
> the 041 test should be hacked to silently skip if it doesn't
> find injection_points available.
Yeah, I like this option. Injection p
I wrote:
> Ugh. The basic issue here is that "make install-world" doesn't
> install anything from underneath src/test/modules, which I recall
> as being an intentional decision. Rather than poking a hole in
> that policy for injection_points, I wonder if we should move it
> to contrib.
... which
Maxim Orlov writes:
> So, my point here: installcheck-world doesn't
> work on the current master branch until I explicitly install
> injection_points extension. In my view, it's a bit wired, since
> neither test_decoding, pg_stat_statements or pg_prewarm demand it.
Ugh. The basic issue here is
Shame on me, I didn't mention one thing in the original email. Actually,
the problem starts for me with "make installcheck-world".
And only then I've run a specific test 041_checkpoint_at_promote.pl. I.e.
the whole sequence of the commands are:
configure --enable_injection_points ...
make world
m
On Mon, 19 Aug 2024 at 19:10, Tom Lane wrote:
> src/test/recovery/README points out that
>
> Also, to use "make installcheck", you must have built and installed
> contrib/pg_prewarm, contrib/pg_stat_statements and contrib/test_decoding
> in addition to the core code.
>
> I suspect this need
Maxim Orlov writes:
> After rebasing one of my old patches, I'm hit to a problem with the
> installcheck test for 041_checkpoint_at_promote.pl.
src/test/recovery/README points out that
Also, to use "make installcheck", you must have built and installed
contrib/pg_prewarm, contrib/pg_stat_sta
Hi!
After rebasing one of my old patches, I'm hit to a problem with the
installcheck test for 041_checkpoint_at_promote.pl.
At first, I thought it was something wrong with my patch, although it
doesn't relate to this part of the Postgres.
Then I decided to do the same run but on current master and
17 matches
Mail list logo
