Re: Test-cases for deferred constraints in plpgsql_transaction.sql

2018-07-04 Thread Peter Eisentraut
On 02.07.18 17:11, Ashutosh Sharma wrote: > Firstly, it would test if the ROLLBACK works as expected when used > with the deferred constraints in plpgsql procedures. Secondly, it > would test if the COMMIT/ROLLBACK works as expected for deferrable > constraints which was initially immediate type bu

Re: Test-cases for deferred constraints in plpgsql_transaction.sql

2018-07-02 Thread Ashutosh Sharma
On Mon, Jul 2, 2018 at 7:07 PM, Tom Lane wrote: > Ashutosh Sharma writes: >> On Mon, Jul 2, 2018 at 3:30 PM, Peter Eisentraut >> wrote: >>> I won't say we don't need more tests, but I don't see a particular >>> testing gap in this area. > >> I am not saying that the existing test-case is not eno

Re: Test-cases for deferred constraints in plpgsql_transaction.sql

2018-07-02 Thread Tom Lane
Ashutosh Sharma writes: > On Mon, Jul 2, 2018 at 3:30 PM, Peter Eisentraut > wrote: >> I won't say we don't need more tests, but I don't see a particular >> testing gap in this area. > I am not saying that the existing test-case is not enough to test > deferred constraints but, it would have bee

Re: Test-cases for deferred constraints in plpgsql_transaction.sql

2018-07-02 Thread Ashutosh Sharma
On Mon, Jul 2, 2018 at 3:30 PM, Peter Eisentraut wrote: > On 02.07.18 11:46, Ashutosh Sharma wrote: >> Currently, I could see only one test-case for deferred constraints in >> plpgsql_transaction.sql file which tests if the constraint checking is >> happening during commit time or not with the hel

Re: Test-cases for deferred constraints in plpgsql_transaction.sql

2018-07-02 Thread Peter Eisentraut
On 02.07.18 11:46, Ashutosh Sharma wrote: > Currently, I could see only one test-case for deferred constraints in > plpgsql_transaction.sql file which tests if the constraint checking is > happening during commit time or not with the help of COMMIT statement. > Shouldn't we add some more test-cases

Test-cases for deferred constraints in plpgsql_transaction.sql

2018-07-02 Thread Ashutosh Sharma
Hi All, Currently, I could see only one test-case for deferred constraints in plpgsql_transaction.sql file which tests if the constraint checking is happening during commit time or not with the help of COMMIT statement. Shouldn't we add some more test-cases to test ROLLBACK and SET CONSTRAINTS sta