Re: TAP test command_fails versus command_fails_like

2025-02-21 Thread Peter Smith
On Thu, Feb 13, 2025 at 12:58 AM Dagfinn Ilmari Mannsåker wrote: > > Ashutosh Bapat writes: > > > On Wed, Feb 12, 2025 at 10:36 AM Peter Smith wrote: > >> > >> Hi hackers, > >> > >> Recently, while writing some new TAP tests my colleague inadvertently > >> called the command_fails() subroutine i

Re: TAP test command_fails versus command_fails_like

2025-02-12 Thread Tom Lane
=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= writes: > Andrew Dunstan writes: >> Is there any reason we can't move to 5.20? Are there any buildfarm >> animals using such an old version? 5.20 is now almost 10 years old. > Red Hat Enterprise Linux 7 has Perl 5.16 and is on Extended Lifecycle > Suppor

Re: TAP test command_fails versus command_fails_like

2025-02-12 Thread Dagfinn Ilmari Mannsåker
Dagfinn Ilmari Mannsåker writes: > Andrew Dunstan writes: > >> On 2025-02-12 We 8:58 AM, Dagfinn Ilmari Mannsåker wrote: >>> Another question is whether command_fails and command_fails_like is the only pair or there are more which need stricter checks? >>> If we do this, we should do i

Re: TAP test command_fails versus command_fails_like

2025-02-12 Thread Dagfinn Ilmari Mannsåker
Andrew Dunstan writes: > On 2025-02-12 We 8:58 AM, Dagfinn Ilmari Mannsåker wrote: >> >>> Another question is whether command_fails and command_fails_like is >>> the only pair or there are more which need stricter checks? >> If we do this, we should do it across the board for >> PostgreSQL::Test:

Re: TAP test command_fails versus command_fails_like

2025-02-12 Thread Andrew Dunstan
On 2025-02-12 We 8:58 AM, Dagfinn Ilmari Mannsåker wrote: Another question is whether command_fails and command_fails_like is the only pair or there are more which need stricter checks? If we do this, we should do it across the board for PostgreSQL::Test::Utils and ::Cluster at least. Once

Re: TAP test command_fails versus command_fails_like

2025-02-12 Thread Dagfinn Ilmari Mannsåker
Ashutosh Bapat writes: > On Wed, Feb 12, 2025 at 10:36 AM Peter Smith wrote: >> >> Hi hackers, >> >> Recently, while writing some new TAP tests my colleague inadvertently >> called the command_fails() subroutine instead of command_fails_like() >> subroutine. Their parameters are almost the same

Re: TAP test command_fails versus command_fails_like

2025-02-12 Thread Ashutosh Bapat
On Wed, Feb 12, 2025 at 10:36 AM Peter Smith wrote: > > Hi hackers, > > Recently, while writing some new TAP tests my colleague inadvertently > called the command_fails() subroutine instead of command_fails_like() > subroutine. Their parameters are almost the same but > command_fails_like() also t

TAP test command_fails versus command_fails_like

2025-02-11 Thread Peter Smith
Hi hackers, Recently, while writing some new TAP tests my colleague inadvertently called the command_fails() subroutine instead of command_fails_like() subroutine. Their parameters are almost the same but command_fails_like() also takes a pattern for checking in the logs. Notice if too many parame