Re: System catalog documentation chapter

2022-07-21 Thread Bruce Momjian
On Wed, Jul 20, 2022 at 09:19:17PM -0400, Bruce Momjian wrote: > On Wed, Jul 20, 2022 at 04:32:46PM -0400, Bruce Momjian wrote: > > On Wed, Jul 20, 2022 at 04:23:21PM -0400, Isaac Morland wrote: > > > Will there be a comprehensive list somewhere? Even if it just lists the > > > views, > > > gives

Re: System catalog documentation chapter

2022-07-20 Thread Bruce Momjian
On Wed, Jul 20, 2022 at 04:32:46PM -0400, Bruce Momjian wrote: > On Wed, Jul 20, 2022 at 04:23:21PM -0400, Isaac Morland wrote: > > Will there be a comprehensive list somewhere? Even if it just lists the > > views, > > gives maybe a one-sentence description, and links to the relevant chapter, I >

Re: System catalog documentation chapter

2022-07-20 Thread Bruce Momjian
On Wed, Jul 20, 2022 at 04:23:21PM -0400, Isaac Morland wrote: > On Wed, 20 Jul 2022 at 16:08, Bruce Momjian wrote: > > On Tue, Jul 19, 2022 at 01:41:44PM -0400, Bruce Momjian wrote: > > I am going to look at moving system views that make sense into the > > chapters where their conten

Re: System catalog documentation chapter

2022-07-20 Thread Isaac Morland
On Wed, 20 Jul 2022 at 16:08, Bruce Momjian wrote: > On Tue, Jul 19, 2022 at 01:41:44PM -0400, Bruce Momjian wrote: > > I am going to look at moving system views that make sense into the > > chapters where their contents are mentioned. I don't think having a > > central list of views is really h

Re: System catalog documentation chapter

2022-07-20 Thread Bruce Momjian
On Tue, Jul 19, 2022 at 01:41:44PM -0400, Bruce Momjian wrote: > I am going to look at moving system views that make sense into the > chapters where their contents are mentioned. I don't think having a > central list of views is really helping us because we expect the views > to be used in ways th

Re: System catalog documentation chapter

2022-07-19 Thread Bruce Momjian
On Mon, Jul 18, 2022 at 09:22:24PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Sat, Jul 16, 2022 at 10:53:17AM +0200, Peter Eisentraut wrote: > >> Maybe this whole notion that "system views" is one thing is not suitable. > > > Are you thinking we should just call the chapter "System Cat

Re: System catalog documentation chapter

2022-07-18 Thread Peter Smith
On Tue, Jul 19, 2022 at 1:22 PM Tom Lane wrote: > > Bruce Momjian writes: > > On Sat, Jul 16, 2022 at 10:53:17AM +0200, Peter Eisentraut wrote: > >> Maybe this whole notion that "system views" is one thing is not suitable. > > > Are you thinking we should just call the chapter "System Catalogs an

Re: System catalog documentation chapter

2022-07-18 Thread Tom Lane
Bruce Momjian writes: > On Sat, Jul 16, 2022 at 10:53:17AM +0200, Peter Eisentraut wrote: >> Maybe this whole notion that "system views" is one thing is not suitable. > Are you thinking we should just call the chapter "System Catalogs and > Views" and just place them alphabetically in a single ch

Re: System catalog documentation chapter

2022-07-18 Thread Bruce Momjian
On Sat, Jul 16, 2022 at 10:53:17AM +0200, Peter Eisentraut wrote: > Now that I see the result, I don't think this is really the right > improvement yet. > > The new System Views chapter lists views that are effectively quasi-system > catalogs, such as pg_shadow or pg_replication_origin_status -- t

Re: System catalog documentation chapter

2022-07-16 Thread Peter Eisentraut
On 14.07.22 22:07, Bruce Momjian wrote: On Tue, Jul 12, 2022 at 05:16:41PM -0400, Bruce Momjian wrote: On Tue, Jul 12, 2022 at 08:56:01PM +0200, Peter Eisentraut wrote: On 08.07.22 18:07, Bruce Momjian wrote: so I guess we can backpatch this with no issues. It inserts a new chapter, which

Re: System catalog documentation chapter

2022-07-14 Thread Bruce Momjian
On Tue, Jul 12, 2022 at 05:16:41PM -0400, Bruce Momjian wrote: > On Tue, Jul 12, 2022 at 08:56:01PM +0200, Peter Eisentraut wrote: > > On 08.07.22 18:07, Bruce Momjian wrote: > > > so I guess we can backpatch this with no issues. > > > > It inserts a new chapter, which would renumber all other cha

Re: System catalog documentation chapter

2022-07-12 Thread Tom Lane
Bruce Momjian writes: > On Tue, Jul 12, 2022 at 08:56:36PM +0200, Peter Eisentraut wrote: >> views.sgml is a pretty generic name for a chapter that just contains system >> views. > Yes, I struggled with that. What made me choose "views" is that the > current name was catalogs.sgml, not syscatalo

Re: System catalog documentation chapter

2022-07-12 Thread Bruce Momjian
On Tue, Jul 12, 2022 at 08:56:36PM +0200, Peter Eisentraut wrote: > On 08.07.22 21:32, Bruce Momjian wrote: > > On Fri, Jul 8, 2022 at 12:07:45PM -0400, Bruce Momjian wrote: > > > On Fri, Jul 8, 2022 at 11:49:47AM -0400, Tom Lane wrote: > > > > Bruce Momjian writes: > > > > > Agreed. I don't wan

Re: System catalog documentation chapter

2022-07-12 Thread Bruce Momjian
On Tue, Jul 12, 2022 at 08:56:01PM +0200, Peter Eisentraut wrote: > On 08.07.22 18:07, Bruce Momjian wrote: > > so I guess we can backpatch this with no issues. > > It inserts a new chapter, which would renumber all other chapters. That's a > pretty big change to backpatch. I'm against that. Oka

Re: System catalog documentation chapter

2022-07-12 Thread Peter Eisentraut
On 08.07.22 21:32, Bruce Momjian wrote: On Fri, Jul 8, 2022 at 12:07:45PM -0400, Bruce Momjian wrote: On Fri, Jul 8, 2022 at 11:49:47AM -0400, Tom Lane wrote: Bruce Momjian writes: Agreed. I don't want to break links into the documentation in final released versions, so head and PG15 seem w

Re: System catalog documentation chapter

2022-07-12 Thread Peter Eisentraut
On 08.07.22 18:07, Bruce Momjian wrote: so I guess we can backpatch this with no issues. It inserts a new chapter, which would renumber all other chapters. That's a pretty big change to backpatch. I'm against that.

Re: System catalog documentation chapter

2022-07-10 Thread Peter Smith
On Sat, Jul 9, 2022 at 5:32 AM Bruce Momjian wrote: > ... > Attached is a patch to accomplish this. Its output can be seen here: > > https://momjian.us/tmp/pgsql/internals.html > That output looks good to me. -- Kind Regards, Peter Smith. Fujitsu Australia

Re: System catalog documentation chapter

2022-07-08 Thread Bruce Momjian
On Fri, Jul 8, 2022 at 12:07:45PM -0400, Bruce Momjian wrote: > On Fri, Jul 8, 2022 at 11:49:47AM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > Agreed. I don't want to break links into the documentation in final > > > released versions, so head and PG15 seem wise. > > > > I would not e

Re: System catalog documentation chapter

2022-07-08 Thread Bruce Momjian
On Fri, Jul 8, 2022 at 11:49:47AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Agreed. I don't want to break links into the documentation in final > > released versions, so head and PG15 seem wise. > > I would not expect this to change the doc URLs for any individual > catalogs or views --

Re: System catalog documentation chapter

2022-07-08 Thread Tom Lane
Bruce Momjian writes: > Agreed. I don't want to break links into the documentation in final > released versions, so head and PG15 seem wise. I would not expect this to change the doc URLs for any individual catalogs or views --- if it does, I won't be happy. regards, tom

Re: System catalog documentation chapter

2022-07-08 Thread Bruce Momjian
On Fri, Jul 8, 2022 at 09:21:13AM +1000, Peter Smith wrote: > > My only question is whether we apply this to head, head & PG 15, or all > > branches? I think the URLs will change with this adjustment so we might > > want to do only head & PG 15. > > AFAIK the chapter has been structured like thi

Re: System catalog documentation chapter

2022-07-07 Thread Peter Smith
On Fri, Jul 8, 2022 at 2:17 AM Bruce Momjian wrote: > > On Thu, Jul 7, 2022 at 09:29:13AM +1000, Peter Smith wrote: > > On Thu, Jun 16, 2022 at 10:59 AM Peter Smith wrote: > > > > > > On Thu, Jun 9, 2022 at 11:50 PM Tom Lane wrote: > > > > > > > > Peter Eisentraut writes: > > > > > Initially,

System catalog documentation chapter

2022-07-07 Thread Bruce Momjian
On Thu, Jul 7, 2022 at 09:29:13AM +1000, Peter Smith wrote: > On Thu, Jun 16, 2022 at 10:59 AM Peter Smith wrote: > > > > On Thu, Jun 9, 2022 at 11:50 PM Tom Lane wrote: > > > > > > Peter Eisentraut writes: > > > > Initially, that chapter did not document any system views. > > > > > > Maybe we