Re: Suspicious redundant assignment in COPY FROM

2023-09-09 Thread Michael Paquier
On Fri, Sep 08, 2023 at 01:54:51PM +0800, Jingtang Zhang wrote: > Agreed with this principle. Patch is modified and attached. Done as of e434e21e1. -- Michael signature.asc Description: PGP signature

Re: Suspicious redundant assignment in COPY FROM

2023-09-07 Thread Jingtang Zhang
Michael Paquier 于2023年9月8日周五 13:42写道: Thanks, Michael~ > The assignment of num_phys_attrs could be kept at the same place as > on HEAD, a bit closer to the palloc0() where it is used. > Agreed with this principle. Patch is modified and attached. -- Jingtang v2-0001-Remove-redundant-assignme

Re: Suspicious redundant assignment in COPY FROM

2023-09-07 Thread Michael Paquier
On Fri, Sep 08, 2023 at 12:23:17PM +0800, Jingtang Zhang wrote: > Hi all, I was reading code of COPY FROM and I found some suspicious > redundant assignment for tuple descriptor and number of attributes. Is > it a behavior on purpose, or an accidently involved by the refactor in > c532d15? Patch is

Suspicious redundant assignment in COPY FROM

2023-09-07 Thread Jingtang Zhang
Hi all, I was reading code of COPY FROM and I found some suspicious redundant assignment for tuple descriptor and number of attributes. Is it a behavior on purpose, or an accidently involved by the refactor in c532d15? Patch is attached. 0001-Remove-redundant-assignment-in-copyfrom.patch Descript