On Sat, 14 Nov 2020 at 18:31, Alexander Korotkov wrote:
> I also have checked that btree_gist is preferred over pg_trgm gist
> index for equality search. Despite our gist cost estimate is quite
> dumb, it selects btree_gist index due to its lower size. So, this
> part also looks good to me.
>
>
On Mon, Nov 16, 2020 at 2:13 AM Jeff Janes wrote:
> On Sat, Nov 14, 2020 at 12:31 AM Alexander Korotkov
> wrote:
>> I went through and revised this patch. I made the documentation
>> statement less categorical. pg_trgm gist/gin indexes might have lower
>> performance of equality operator searc
On Sat, Nov 14, 2020 at 12:31 AM Alexander Korotkov
wrote:
>
> I went through and revised this patch. I made the documentation
> statement less categorical. pg_trgm gist/gin indexes might have lower
> performance of equality operator search than B-tree. So, we can't
> claim the B-tree index is
On 2020-11-15 06:55, Alexander Korotkov wrote:
> Sorry to be nitpicking - it's the one thing I'm really good at :P
Hi Alexander,
The last touch... (you forgot the missing 'the')
thanks!
Erik Rijkers
--- doc/src/sgml/pgtrgm.sgml.orig 2020-11-15 08:00:54.607816533 +0100
+++ doc/src/sgml/pgtrg
On Sun, Nov 15, 2020 at 1:55 PM Alexander Korotkov wrote:
>
> On Sat, Nov 14, 2020 at 8:26 PM Julien Rouhaud wrote:
> > On Sat, Nov 14, 2020 at 7:58 PM Erik Rijkers wrote:
> > >
> > > On 2020-11-14 12:53, Julien Rouhaud wrote:
> > > > On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov
> > > > >
On Sat, Nov 14, 2020 at 8:26 PM Julien Rouhaud wrote:
> On Sat, Nov 14, 2020 at 7:58 PM Erik Rijkers wrote:
> >
> > On 2020-11-14 12:53, Julien Rouhaud wrote:
> > > On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov
> > > >
> >
> > >Note that those indexes may not be as afficient as regulat
On Sat, Nov 14, 2020 at 7:58 PM Erik Rijkers wrote:
>
> On 2020-11-14 12:53, Julien Rouhaud wrote:
> > On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov
> > >
>
> >Note that those indexes may not be as afficient as regulat B-tree
> > indexes
> >for equality operator.
>
>
> 'afficient as
On 2020-11-14 12:53, Julien Rouhaud wrote:
On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov
>
Note that those indexes may not be as afficient as regulat B-tree
indexes
for equality operator.
'afficient as regulat' should be
'efficient as regular'
Sorry to be nitpicking - it's t
On Sat, Nov 14, 2020 at 6:07 PM Alexander Korotkov wrote:
>
> Hi, Erik!
>
> On Sat, Nov 14, 2020 at 11:37 AM Erik Rijkers wrote:
> > On 2020-11-14 06:30, Alexander Korotkov wrote:
> >
> > > [v4-0001-Handle-equality...in-contrib-pg_trgm.patch (~]
> > >
> > > I'm going to push this if no objections
Hi, Erik!
On Sat, Nov 14, 2020 at 11:37 AM Erik Rijkers wrote:
> On 2020-11-14 06:30, Alexander Korotkov wrote:
>
> > [v4-0001-Handle-equality...in-contrib-pg_trgm.patch (~]
> >
> > I'm going to push this if no objections.
> >
>
> About the sgml, in doc/src/sgml/pgtrgm.sgml :
>
>
> Beginning in P
On 2020-11-14 06:30, Alexander Korotkov wrote:
[v4-0001-Handle-equality...in-contrib-pg_trgm.patch (~]
I'm going to push this if no objections.
About the sgml, in doc/src/sgml/pgtrgm.sgml :
Beginning in PostgreSQL 14, these indexes
also support equality operator (simple comparison operato
Hi!
On Fri, Nov 13, 2020 at 1:47 PM Georgios wrote:
> In short, I think v3 of the patch looks good to change to 'RFC' status.
> Given the possible costing concerns, I will refrain from changing the
> status just yet, to give the opportunity to more reviewers to chime in.
> If in the next few days
‐‐‐ Original Message ‐‐‐
On Friday, November 13, 2020 10:50 AM, Julien Rouhaud
wrote:
> On Wed, Nov 11, 2020 at 8:34 PM Georgios Kokolatos
> gkokola...@protonmail.com wrote:
>
> > The following review has been posted through the commitfest application:
> > make installcheck-world: tes
On Wed, Nov 11, 2020 at 8:34 PM Georgios Kokolatos
wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation:not tested
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Hi,
this patch implements a useful and missing feature. Thank you.
On Mon, Oct 26, 2020 at 7:38 AM Julien Rouhaud wrote:
> Ah, yes this might lead to bad performance if the "fake wildcard"
> matches too many rows, but this shouldn't be a very common use case,
> and the only alternative for that might be to create trigrams for non
> alphanumerics characters. I di
On Mon, Oct 26, 2020 at 12:19 PM Tom Lane wrote:
>
> Julien Rouhaud writes:
> > On Mon, Oct 26, 2020 at 5:03 AM Tom Lane wrote:
> >> I think you may be overoptimistic about being able to use the identical
> >> code path without regard for LIKE wildcards; but certainly it should be
> >> possible
Julien Rouhaud writes:
> On Mon, Oct 26, 2020 at 5:03 AM Tom Lane wrote:
>> I think you may be overoptimistic about being able to use the identical
>> code path without regard for LIKE wildcards; but certainly it should be
>> possible to do this with not a lot of new code. +1.
> Well, that's wh
On Mon, Oct 26, 2020 at 12:02 PM Julien Rouhaud wrote:
>
> On Mon, Oct 26, 2020 at 5:03 AM Tom Lane wrote:
> >
> > Julien Rouhaud writes:
> > > A french user recently complained that with an index created using
> > > gin_trgm_ops (or gist_trgm_ops), you can use the index with a clause
> > > like
On Mon, Oct 26, 2020 at 5:03 AM Tom Lane wrote:
>
> Julien Rouhaud writes:
> > A french user recently complained that with an index created using
> > gin_trgm_ops (or gist_trgm_ops), you can use the index with a clause
> > like
> > col LIKE 'something'
> > but not
> > col = 'something'
>
> Huh, I
Julien Rouhaud writes:
> A french user recently complained that with an index created using
> gin_trgm_ops (or gist_trgm_ops), you can use the index with a clause
> like
> col LIKE 'something'
> but not
> col = 'something'
Huh, I'd supposed we did that already.
> even though both clauses are tec
Hello,
A french user recently complained that with an index created using
gin_trgm_ops (or gist_trgm_ops), you can use the index with a clause
like
col LIKE 'something'
but not
col = 'something'
even though both clauses are technically identical. That's clearly
not a high priority thing to su
22 matches
Mail list logo
