On Mon, 8 Jul 2024 at 17:52, jian he wrote:
>
> On Mon, Jul 8, 2024 at 1:16 PM David Rowley wrote:
> > Updated patch attached.
>
> looking good to me.
Thanks for reviewing. I've pushed the patch now.
David
On Mon, Jul 8, 2024 at 1:16 PM David Rowley wrote:
>
>
> Updated patch attached.
>
looking good to me.
On Mon, 8 Jul 2024 at 16:43, jian he wrote:
> { oid => '2031',
> proname => 'timestamp_mi', prorettype => 'interval',
> proargtypes => 'timestamp timestamp', prosrc => 'timestamp_mi' },
> { oid => '1188',
> proname => 'timestamptz_mi', prorettype => 'interval',
> proargtypes => 'timestampt
On Mon, Jul 8, 2024 at 12:02 PM David Rowley wrote:
>
> > /*
> > * Protect against overflows in timestamp_mi. XXX convert to
> > * ereturn one day?
> > */
> > if (!TIMESTAMP_NOT_FINITE(start) && !TIMESTAMP_NOT_FINITE(finish) &&
> > !pg_sub_s64_overflow(finish, start, &dummy))
> >
> > i don't unde
On Mon, 8 Jul 2024 at 14:50, jian he wrote:
>
> looks good to me.
Thanks for looking.
> /*
> * Protect against overflows in timestamp_mi. XXX convert to
> * ereturn one day?
> */
> if (!TIMESTAMP_NOT_FINITE(start) && !TIMESTAMP_NOT_FINITE(finish) &&
> !pg_sub_s64_overflow(finish, start, &dummy)
looks good to me.
some minor questions:
/*
* Protect against overflows in timestamp_mi. XXX convert to
* ereturn one day?
*/
if (!TIMESTAMP_NOT_FINITE(start) && !TIMESTAMP_NOT_FINITE(finish) &&
!pg_sub_s64_overflow(finish, start, &dummy))
i don't understand the comment "XXX convert to ereturn on
On Sun, 14 Apr 2024 at 15:14, David Rowley wrote:
> I had some spare time today, so wrote a patch, which gives you:
>
> postgres=# explain analyze select * from generate_series('2024-01-01',
> '2025-01-01', interval '1 day');
> QUERY PLAN
> -
When looking at [1], I noticed that we don't have a prosupport
function for the timestamp version of generate_series.
We have this for the integer versions of generate_series(), per:
postgres=# explain analyze select * from generate_series(1, 256, 2);
