Re: Support for runtime parameters in injection points, for AIO tests

2025-05-09 Thread Michael Paquier
On Fri, May 09, 2025 at 03:59:48PM +, Greg Burd wrote: > Apologies for that, somehow the wrong version of that file was > attached. I'll be more careful next time. No problem. This was mostly the same as the original. There was a fuzz in 0001, actually, fixed by 0003 with the definitions of

Re: Support for runtime parameters in injection points, for AIO tests

2025-05-08 Thread Michael Paquier
On Fri, May 09, 2025 at 10:48:45AM +0900, Michael Paquier wrote: > Thanks for the input. Will proceed if there are no objections, then. By the way, Greg, v2-0003 in the patch set you have posted was incorrect; it missed most of the wanted changes to get rid of the workarounds in the AIO code. Co

Re: Support for runtime parameters in injection points, for AIO tests

2025-05-08 Thread Michael Paquier
On Thu, May 08, 2025 at 09:18:15PM -0400, Andres Freund wrote: > I'm ok with it happening now or only in master after branching off. Either > seems justifiable to me. I really don't have much of an opinion about it - it > seems you do, so we should probably go with that. Thanks for the input. Wi

Re: Support for runtime parameters in injection points, for AIO tests

2025-05-08 Thread Andres Freund
Hi, On 2025-05-09 08:19:39 +0900, Michael Paquier wrote: > On Thu, May 08, 2025 at 06:16:46PM +, Greg Burd wrote: > > IMO seems like a good idea, happy to help further "cleanup the AIO > > code" with some direction as to what needs to be done. > > Thanks for posting a rebase. Yes, I would li

Re: Support for runtime parameters in injection points, for AIO tests

2025-05-08 Thread Michael Paquier
On Thu, May 08, 2025 at 06:16:46PM +, Greg Burd wrote: > IMO seems like a good idea, happy to help further "cleanup the AIO > code" with some direction as to what needs to be done. Thanks for posting a rebase. Yes, I would like to clean up that on HEAD, but it also seems like Andres would pre

Re: Support for runtime parameters in injection points, for AIO tests

2025-04-16 Thread Michael Paquier
On Mon, Apr 14, 2025 at 04:05:40AM -0400, Andres Freund wrote: > On 2025-04-14 16:46:22 +0900, Michael Paquier wrote: >> We are still in early April, and I'd like to propose a cleanup of the >> AIO code on HEAD, even if we are post-feature freeze, to not release >> this new code in this state, impl

Re: Support for runtime parameters in injection points, for AIO tests

2025-04-15 Thread Andres Freund
Hi, On 2025-04-14 16:46:22 +0900, Michael Paquier wrote: > While reading the AIO code I have noticed that the way it uses > injection points is limited by the fact that we don't have support for > runtime parameters in the existing injection point facility. Yep. > The code is shaped with two se

Support for runtime parameters in injection points, for AIO tests

2025-04-14 Thread Michael Paquier
Hi all, (Andres in CC.) While reading the AIO code I have noticed that the way it uses injection points is limited by the fact that we don't have support for runtime parameters in the existing injection point facility. The code is shaped with two set/get functions that set a static parameter that