Re: Strange code in EXPLAIN for queryid

2021-08-08 Thread David Rowley
On Mon, 9 Aug 2021 at 02:06, Julien Rouhaud wrote: > > Any objection to applying the attached to pg14 and master? > > No objection. Thanks for looking. I've now pushed this to master and pg14. David

Re: Strange code in EXPLAIN for queryid

2021-08-08 Thread Julien Rouhaud
On Sun, Aug 08, 2021 at 11:56:41PM +1200, David Rowley wrote: > > On looking a little closer I also saw that plannedstmt->queryId is a > uint64. I guess that we're showing this as an int64 so that it > matches the queryid column in the pg_stat_statements view? The only reason we display it as an

Strange code in EXPLAIN for queryid

2021-08-08 Thread David Rowley
I was wondering about the following code in explain.c char buf[MAXINT8LEN + 1]; pg_lltoa(plannedstmt->queryId, buf); ExplainPropertyText("Query Identifier", buf, es); I thought it was a bit strange that we don't just use ExplainPropertyInteger() instead of going to the trouble of building the st