Re: Strange assertion in procarray.c

2025-02-20 Thread Mihail Nikalayeu
Hello! Noah, I have noticed you already disabled runningcheck for isolation tests already in injection_points[0]. The whole patch here was about to make it default for all types of tests for injection_points. Seems like we may close this entry. Attached patch is just to put a rebased version her

Re: Strange assertion in procarray.c

2025-01-12 Thread Michail Nikolaev
Hello, everyone! Decide just to clarify - the patch is failing on CFbot [0], but it is as designed - it contains a reproducer which shows how unrelated backends may affect each other even in case of **local** injection points, causing the crash. Best regards, Michail. [0]: https://cirrus-ci.com/

Re: Strange assertion in procarray.c

2024-11-29 Thread Michail Nikolaev
Hello, Michael! > I fail to see how this is related? The original issue was that this > was impossible to run safely concurrently, but now we have the > facilities able to do so. There are a few cases where using a wait > point has limits, for example outside a transaction context for some > of

Re: Strange assertion in procarray.c

2024-11-28 Thread Michael Paquier
On Thu, Nov 28, 2024 at 09:04:36PM +0100, Michail Nikolaev wrote: > I discovered that a similar issue was previously addressed by Heikki in > commit [0], where installcheck was disabled for injection point tests. > However, in the meson build configuration, this was only applied to > regression tes

Re: Strange assertion in procarray.c

2024-11-28 Thread Michail Nikolaev
Hello, Heikki, Nathan and Michael! Oh, please excuse my impudence in bringing you all here, but I finally found what almost the same issue was fixed by Heikki already [0]. I discovered that a similar issue was previously addressed by Heikki in commit [0], where installcheck was disabled for injec

Re: Strange assertion in procarray.c

2024-11-27 Thread Michail Nikolaev
Hello, again. > Another backend attempts to release the same resource (e.g., by aborting a transaction) and triggers the injection point. Oh, all that GPT-like correctors required to be carefully checked :) Correct version: Another backend attempts to release some resource (e.g., by aborting a tr

Re: Strange assertion in procarray.c

2024-11-26 Thread Michail Nikolaev
Hello, Nathan and Michael! I believe I’ve identified the root cause of the issue. It appears to be related to the GetNamedDSMSegment and injection_points module. Here’s how it happens: * A backend attaches (even locally!) to an injection point, which might get triggered during resource release (