On Mon, May 03, 2021 at 02:59:42PM -0400, Bruce Momjian wrote:
> On Sun, May 2, 2021 at 12:27:37PM +0800, Julien Rouhaud wrote:
> > Hi Aleksander,
> >
> > On Wed, Apr 28, 2021 at 03:22:39PM +0300, Aleksander Alekseev wrote:
> > > Hi Julien,
> > >
> > > > You should see failures doing a check-wor
On Sun, May 2, 2021 at 12:27:37PM +0800, Julien Rouhaud wrote:
> Hi Aleksander,
>
> On Wed, Apr 28, 2021 at 03:22:39PM +0300, Aleksander Alekseev wrote:
> > Hi Julien,
> >
> > > You should see failures doing a check-world or simply a make -C
> > > contrib/pg_stat_statements check
> >
> > Sorry,
Hi Aleksander,
On Wed, Apr 28, 2021 at 03:22:39PM +0300, Aleksander Alekseev wrote:
> Hi Julien,
>
> > You should see failures doing a check-world or simply a make -C
> > contrib/pg_stat_statements check
>
> Sorry, my bad. I was running make check-world, but did it with -j4 flag
> which was a mi
Hi Julien,
> You should see failures doing a check-world or simply a make -C
> contrib/pg_stat_statements check
Sorry, my bad. I was running make check-world, but did it with -j4 flag
which was a mistake.
The patch is OK.
On Wed, Apr 28, 2021 at 1:27 PM Julien Rouhaud wrote:
> Hi Aleksander,
Hi Aleksander,
On Wed, Apr 28, 2021 at 01:19:36PM +0300, Aleksander Alekseev wrote:
> Hi Julien,
>
> > I'm attaching a patch that fixes those, with regression tests to reproduce
> > each
> > problem.
>
> I believe something could be not quite right with the patch. Here is what I
> did:
>
> $
Hi Julien,
> I'm attaching a patch that fixes those, with regression tests to reproduce
> each
> problem.
I believe something could be not quite right with the patch. Here is what I did:
$ git apply ...
# revert the changes in the code but keep the new tests
$ git checkout src/backend/utils/mis
gt;From cf4ee4b493cdb730b7ac98d65bcca785455af7ce Mon Sep 17 00:00:00 2001
From: Julien Rouhaud
Date: Sun, 25 Apr 2021 15:49:32 +0800
Subject: [PATCH v1] Fix some oversights in query_id calculation.
---
.../expected/pg_stat_statements.out | 151 ++
.../sql/pg_stat_stateme
