Re: Some incorrect option sizes for PQconninfoOption in libpq

2020-01-28 Thread Michael Paquier
On Tue, Jan 28, 2020 at 11:57:19AM +0100, Daniel Gustafsson wrote: > Nice catch! +1 on the attached patch. Thanks, fixed and backpatched down to 12, where gssencmode has been added. -- Michael signature.asc Description: PGP signature

Re: Some incorrect option sizes for PQconninfoOption in libpq

2020-01-28 Thread Daniel Gustafsson
> On 28 Jan 2020, at 06:36, Michael Paquier wrote: > I was reviewing the libpq code for the recent SSL protocol patch, and > noticed two mistakes with dispsize for the following parameters: > - channel_binding should be at 8, the largest value being "require". > - gssencmode should be at 8. > >

Some incorrect option sizes for PQconninfoOption in libpq

2020-01-27 Thread Michael Paquier
Hi all, I was reviewing the libpq code for the recent SSL protocol patch, and noticed two mistakes with dispsize for the following parameters: - channel_binding should be at 8, the largest value being "require". - gssencmode should be at 8. In those cases the zero-terminator was forgotten in the