Re: Soft errors and ThrowErrorData() comment updates

2024-10-17 Thread Corey Huinker
On Wed, Oct 16, 2024 at 4:20 PM Jeff Davis wrote: > The comments around ThrowErrorData() and how it might apply to soft > errors is slightly confusing. Attached a patch which hopefully > clarifies things. > > From a distance, ThrowErrorData() is somewhat like ReThrowError(), but > it's actually q

Soft errors and ThrowErrorData() comment updates

2024-10-16 Thread Jeff Davis
The comments around ThrowErrorData() and how it might apply to soft errors is slightly confusing. Attached a patch which hopefully clarifies things. >From a distance, ThrowErrorData() is somewhat like ReThrowError(), but it's actually quite different. The former is expecting a free-standing ErrorD