вт, 13 авг. 2019 г. в 06:19, Michael Paquier :
>
> On Fri, Aug 09, 2019 at 11:21:52AM +0300, Dmitry Igrishin wrote:
> > Personally I don't care. I used || notation only in order to be
> > consistent, since this notation is already used in Solution.pm. If
> > this consistency is not required let me
On Fri, Aug 09, 2019 at 11:21:52AM +0300, Dmitry Igrishin wrote:
> Personally I don't care. I used || notation only in order to be
> consistent, since this notation is already used in Solution.pm. If
> this consistency is not required let me provide a patch with {}
> notation. What do you think?
W
пт, 9 авг. 2019 г. в 10:23, Kyotaro Horiguchi :
>
> At Fri, 9 Aug 2019 09:56:27 +0300, Dmitry Igrishin wrote
> in
> > пт, 9 авг. 2019 г. в 05:45, Michael Paquier :
> > >
> > > On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote:
> > > > This looks nice for a Perl hacker :-). As for m
At Fri, 9 Aug 2019 09:56:27 +0300, Dmitry Igrishin wrote in
> пт, 9 авг. 2019 г. в 05:45, Michael Paquier :
> >
> > On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote:
> > > This looks nice for a Perl hacker :-). As for me, it looks unusual and
> > > a bit confusing. I never
> > > p
пт, 9 авг. 2019 г. в 05:45, Michael Paquier :
>
> On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote:
> > This looks nice for a Perl hacker :-). As for me, it looks unusual and
> > a bit confusing. I never
> > programmed in Perl, but I was able to quickly understand where the
> > probl
On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote:
> This looks nice for a Perl hacker :-). As for me, it looks unusual and
> a bit confusing. I never
> programmed in Perl, but I was able to quickly understand where the
> problem lies due to the
> style adopted in other languages, wh
Hello.
At Thu, 08 Aug 2019 12:15:38 +0900 (Tokyo Standard Time), Kyotaro Horiguchi
wrote in
<20190808.121538.87367461.horikyota@gmail.com>
> At Wed, 7 Aug 2019 12:14:48 +0300, Dmitry Igrishin wrote
> in
> > > -if ($lib =~ m/\s/)
> > > -{
> > > -$lib = '"' . $lib . """;
>
чт, 8 авг. 2019 г. в 20:07, Alvaro Herrera :
>
> On 2019-Aug-08, Dmitry Igrishin wrote:
>
> > my $prefixcmd =
> > - $solution->{options}->{python} . "\\python -c
> > \"$pythonprog\"";
> > + "\"$solution->{options}->{python}\\python\" -c
> > \"$pythonprog\
On 2019-Aug-08, Dmitry Igrishin wrote:
> my $prefixcmd =
> - $solution->{options}->{python} . "\\python -c
> \"$pythonprog\"";
> + "\"$solution->{options}->{python}\\python\" -c
> \"$pythonprog\"";
I think you can make this prettier like this:
my $p
> > As for the replace comment, I'm not
> > sure it is needed since I think quoting is not the task for
> > AddLibrary/AddIncludeDir in the first place (and AddIncludeDir
> > doesn't have the same comment).
The attached 3rd version of the patch contains no comment in AddLibrary().
Sorry, forgot to
чт, 8 авг. 2019 г. в 06:18, Kyotaro Horiguchi :
>
> Hello.
>
> At Wed, 7 Aug 2019 12:14:48 +0300, Dmitry Igrishin wrote
> in
> > > -if ($lib =~ m/\s/)
> > > -{
> > > -$lib = '"' . $lib . """;
> > > -}
> > > +# Since VC automatically quotes paths specified as the data of
>
Hello.
At Wed, 7 Aug 2019 12:14:48 +0300, Dmitry Igrishin wrote in
> > -if ($lib =~ m/\s/)
> > -{
> > -$lib = '"' . $lib . """;
> > -}
> > +# Since VC automatically quotes paths specified as the data of
> > +# in VC project file, it's mistakably
> > +# to quote
ср, 7 авг. 2019 г. в 15:33, Juan José Santamaría Flecha
:
>
> On Wed, Aug 7, 2019 at 11:11 AM Dmitry Igrishin wrote:
> >
> > ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi :
> > >
> > > Solution.pm has the following line:
> > >
> > > > my $opensslcmd =
> > > > $self->{options}->{opens
On Wed, Aug 7, 2019 at 11:11 AM Dmitry Igrishin wrote:
>
> ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi :
> >
> > Solution.pm has the following line:
> >
> > > my $opensslcmd =
> > > $self->{options}->{openssl} . "\\bin\\openssl.exe version 2>&1";
> >
> > AFAICS that's all.
> Thank
ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi :
>
> Hi,
>
> At Tue, 6 Aug 2019 22:50:14 +0300, Dmitry Igrishin wrote
> in
> > The attached self-documented patch fixes build on Windows in case when
> > path to Python has embedded spaces.
>
> - $solution->{options}->{python} . "\\python -
Hi,
At Tue, 6 Aug 2019 22:50:14 +0300, Dmitry Igrishin wrote in
> The attached self-documented patch fixes build on Windows in case when
> path to Python has embedded spaces.
- $solution->{options}->{python} . "\\python -c \"$pythonprog\"";
+ "\"$solution->{options}->{python}
Hi,
The attached self-documented patch fixes build on Windows in case when
path to Python has embedded spaces.
diff --git a/src/tools/msvc/Mkvcbuild.pm b/src/tools/msvc/Mkvcbuild.pm
index d1d0aed07e..76834f5188 100644
--- a/src/tools/msvc/Mkvcbuild.pm
+++ b/src/tools/msvc/Mkvcbuild.pm
@@ -495,7 +4
17 matches
Mail list logo
