Re: Small fixes about backup history file in doc and pg_standby

2018-07-01 Thread Peter Eisentraut
On 27.06.18 18:22, Yugo Nagata wrote: > On Wed, 27 Jun 2018 18:36:46 +0900 > Michael Paquier wrote: > >> On Wed, Jun 27, 2018 at 05:42:07PM +0900, Yugo Nagata wrote: >>> On Wed, 27 Jun 2018 00:58:18 +0900 >>> Fujii Masao wrote: > In addition, the current pg_standby still can handle a backup

Re: Small fixes about backup history file in doc and pg_standby

2018-06-27 Thread Yugo Nagata
On Wed, 27 Jun 2018 18:36:46 +0900 Michael Paquier wrote: > On Wed, Jun 27, 2018 at 05:42:07PM +0900, Yugo Nagata wrote: > > On Wed, 27 Jun 2018 00:58:18 +0900 > > Fujii Masao wrote: > >>> In addition, the current pg_standby still can handle a backup history > >>> file that are > >>> never requ

Re: Small fixes about backup history file in doc and pg_standby

2018-06-27 Thread Michael Paquier
On Wed, Jun 27, 2018 at 05:42:07PM +0900, Yugo Nagata wrote: > On Wed, 27 Jun 2018 00:58:18 +0900 > Fujii Masao wrote: >>> In addition, the current pg_standby still can handle a backup history file >>> that are >>> never requested. It is harmless but unnecessary code. Another attached patch >>> (

Re: Small fixes about backup history file in doc and pg_standby

2018-06-27 Thread Yugo Nagata
On Tue, 26 Jun 2018 20:19:42 +0900 (Tokyo Standard Time) Kyotaro HORIGUCHI wrote: > Hello. > > Good catch! > > At Tue, 26 Jun 2018 17:47:52 +0900, Yugo Nagata wrote > in <20180626174752.0ce505e3.nag...@sraoss.co.jp> > > Hi, > > > > While looking into the backup and recovery code, I found sma

Re: Small fixes about backup history file in doc and pg_standby

2018-06-27 Thread Yugo Nagata
On Wed, 27 Jun 2018 00:58:18 +0900 Fujii Masao wrote: > On Tue, Jun 26, 2018 at 5:47 PM, Yugo Nagata wrote: > > Hi, > > > > While looking into the backup and recovery code, I found small > > documentation bugs. > > The documatation says that the backup history files can be requested for > > re

Re: Small fixes about backup history file in doc and pg_standby

2018-06-26 Thread Fujii Masao
On Tue, Jun 26, 2018 at 5:47 PM, Yugo Nagata wrote: > Hi, > > While looking into the backup and recovery code, I found small documentation > bugs. > The documatation says that the backup history files can be requested for > recovery, > but it's not used by the system and not requested anymore si

Re: Small fixes about backup history file in doc and pg_standby

2018-06-26 Thread Kyotaro HORIGUCHI
Hello. Good catch! At Tue, 26 Jun 2018 17:47:52 +0900, Yugo Nagata wrote in <20180626174752.0ce505e3.nag...@sraoss.co.jp> > Hi, > > While looking into the backup and recovery code, I found small documentation > bugs. > The documatation says that the backup history files can be requested for

Small fixes about backup history file in doc and pg_standby

2018-06-26 Thread Yugo Nagata
Hi, While looking into the backup and recovery code, I found small documentation bugs. The documatation says that the backup history files can be requested for recovery, but it's not used by the system and not requested anymore since PG 9.0 (commit 06f82b29616cd9effcaefd99c6b6e2e80697482f) an