Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-09-20 Thread Masahiko Sawada
On Wed, Sep 15, 2021 at 4:58 PM Daniel Gustafsson wrote: > > > On 14 Sep 2021, at 14:35, Daniel Gustafsson wrote: > > > >> On 14 Sep 2021, at 11:57, Amit Kapila wrote: > > > >> LGTM as well. Peter E., Daniel, does any one of you is intending to > >> push this? If not, I can take care of this. >

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-09-15 Thread Daniel Gustafsson
> On 14 Sep 2021, at 14:35, Daniel Gustafsson wrote: > >> On 14 Sep 2021, at 11:57, Amit Kapila wrote: > >> LGTM as well. Peter E., Daniel, does any one of you is intending to >> push this? If not, I can take care of this. > > No worries, I can pick it up. And done, thanks! -- Daniel Gustafs

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-09-14 Thread Daniel Gustafsson
> On 14 Sep 2021, at 11:57, Amit Kapila wrote: > LGTM as well. Peter E., Daniel, does any one of you is intending to > push this? If not, I can take care of this. No worries, I can pick it up. -- Daniel Gustafsson https://vmware.com/

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-09-14 Thread Amit Kapila
On Wed, Sep 8, 2021 at 5:11 PM Masahiko Sawada wrote: > > On Tue, Sep 7, 2021 at 9:01 PM Daniel Gustafsson wrote: > > > > > On 7 Sep 2021, at 13:36, Peter Eisentraut > > > wrote: > > > > > > On 12.08.21 04:52, Masahiko Sawada wrote: > > >> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson > >

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-09-08 Thread Masahiko Sawada
On Tue, Sep 7, 2021 at 9:01 PM Daniel Gustafsson wrote: > > > On 7 Sep 2021, at 13:36, Peter Eisentraut > > wrote: > > > > On 12.08.21 04:52, Masahiko Sawada wrote: > >> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson wrote: > >>> > On 11 Aug 2021, at 09:57, Masahiko Sawada wrote: > >>>

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-09-07 Thread Daniel Gustafsson
> On 7 Sep 2021, at 13:36, Peter Eisentraut > wrote: > > On 12.08.21 04:52, Masahiko Sawada wrote: >> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson wrote: >>> On 11 Aug 2021, at 09:57, Masahiko Sawada wrote: >>> Additionally, refresh options as described in refresh_option

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-09-07 Thread Peter Eisentraut
On 12.08.21 04:52, Masahiko Sawada wrote: On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson wrote: On 11 Aug 2021, at 09:57, Masahiko Sawada wrote: Additionally, refresh options as described in refresh_option of REFRESH PUBLICATION may be specified, except in the case of DROP PUBLICATION.

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-11 Thread Greg Nancarrow
On Thu, Aug 12, 2021 at 12:53 PM Masahiko Sawada wrote: > > Yeah, I prefer my original patch over this idea. On the other hand, I > can see the point of review comment on it that Amit pointed out[1]. > > Regards, > > [1] > https://www.postgresql.org/message-id/CAA4eK1KaWwUSkDEKPseVY-z00kQJfpfVFdJ

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-11 Thread Masahiko Sawada
On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson wrote: > > > On 11 Aug 2021, at 09:57, Masahiko Sawada wrote: > > > Additionally, refresh options as described in > > refresh_option of > > REFRESH PUBLICATION may be specified, > > except in the case of DROP PUBLICATION. > > Since this paragraph

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-11 Thread Daniel Gustafsson
> On 11 Aug 2021, at 09:57, Masahiko Sawada wrote: > Additionally, refresh options as described in > refresh_option of > REFRESH PUBLICATION may be specified, > except in the case of DROP PUBLICATION. Since this paragraph is under the literal option “refresh”, which takes a value, I still find y

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-11 Thread Masahiko Sawada
On Tue, Aug 10, 2021 at 12:28 PM Amit Kapila wrote: > > On Tue, Aug 10, 2021 at 6:31 AM Masahiko Sawada wrote: > > > > On Mon, Aug 9, 2021 at 1:01 PM Peter Smith wrote: > > > > > > On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila > > > wrote: > > > > But "REFRESH PUBLICATION refresh_option" seems w

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-09 Thread Amit Kapila
On Tue, Aug 10, 2021 at 6:31 AM Masahiko Sawada wrote: > > On Mon, Aug 9, 2021 at 1:01 PM Peter Smith wrote: > > > > On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila wrote: > > But "REFRESH PUBLICATION refresh_option" seems wrong in terms of SQL > syntax, not? > > Given there could be multiple option

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-09 Thread Peter Smith
On Tue, Aug 10, 2021 at 11:01 AM Masahiko Sawada wrote: > > On Mon, Aug 9, 2021 at 1:01 PM Peter Smith wrote: > > > > On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila wrote: > > > > > > On Sun, Aug 8, 2021 at 10:21 AM Peter Smith wrote: > > > > > > > > On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila >

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-09 Thread Masahiko Sawada
On Mon, Aug 9, 2021 at 1:01 PM Peter Smith wrote: > > On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila wrote: > > > > On Sun, Aug 8, 2021 at 10:21 AM Peter Smith wrote: > > > > > > On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila > > > wrote: > > > > > > > > On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-08 Thread Peter Smith
On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila wrote: > > On Sun, Aug 8, 2021 at 10:21 AM Peter Smith wrote: > > > > On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila wrote: > > > > > > On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada > > > wrote: > > > > > > > > Hi all, > > > > > > > > When reading the d

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-08 Thread Amit Kapila
On Sun, Aug 8, 2021 at 10:21 AM Peter Smith wrote: > > On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila wrote: > > > > On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada > > wrote: > > > > > > Hi all, > > > > > > When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh > > > options' in the fo

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-07 Thread Peter Smith
On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila wrote: > > On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada wrote: > > > > Hi all, > > > > When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh > > options' in the following paragraph is not tagged: > > > > --- > > Additionally, refresh opti

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-08-06 Thread Amit Kapila
On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada wrote: > > Hi all, > > When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh > options' in the following paragraph is not tagged: > > --- > Additionally, refresh options as described under REFRESH PUBLICATION > may be specified, except i

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-07-12 Thread Masahiko Sawada
Hi, On Thu, Jul 8, 2021 at 10:14 PM Daniel Gustafsson wrote: > > > On 8 Jul 2021, at 15:00, Masahiko Sawada wrote: > > > I think we can improve it by changing to > > 'refresh_option'. Thoughts? > > My first thought was that the existing wording is clearer, referring to > “options to refresh”. B

Re: Small documentation improvement for ALTER SUBSCRIPTION

2021-07-08 Thread Daniel Gustafsson
> On 8 Jul 2021, at 15:00, Masahiko Sawada wrote: > I think we can improve it by changing to > 'refresh_option'. Thoughts? My first thought was that the existing wording is clearer, referring to “options to refresh”. But thinking on it more, it’s easy to see someone confusing the options part a

Small documentation improvement for ALTER SUBSCRIPTION

2021-07-08 Thread Masahiko Sawada
Hi all, When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh options' in the following paragraph is not tagged: --- Additionally, refresh options as described under REFRESH PUBLICATION may be specified, except in the case of DROP PUBLICATION. --- When I read it for the first time,