On Wed, Sep 15, 2021 at 4:58 PM Daniel Gustafsson wrote:
>
> > On 14 Sep 2021, at 14:35, Daniel Gustafsson wrote:
> >
> >> On 14 Sep 2021, at 11:57, Amit Kapila wrote:
> >
> >> LGTM as well. Peter E., Daniel, does any one of you is intending to
> >> push this? If not, I can take care of this.
>
> On 14 Sep 2021, at 14:35, Daniel Gustafsson wrote:
>
>> On 14 Sep 2021, at 11:57, Amit Kapila wrote:
>
>> LGTM as well. Peter E., Daniel, does any one of you is intending to
>> push this? If not, I can take care of this.
>
> No worries, I can pick it up.
And done, thanks!
--
Daniel Gustafs
> On 14 Sep 2021, at 11:57, Amit Kapila wrote:
> LGTM as well. Peter E., Daniel, does any one of you is intending to
> push this? If not, I can take care of this.
No worries, I can pick it up.
--
Daniel Gustafsson https://vmware.com/
On Wed, Sep 8, 2021 at 5:11 PM Masahiko Sawada wrote:
>
> On Tue, Sep 7, 2021 at 9:01 PM Daniel Gustafsson wrote:
> >
> > > On 7 Sep 2021, at 13:36, Peter Eisentraut
> > > wrote:
> > >
> > > On 12.08.21 04:52, Masahiko Sawada wrote:
> > >> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson
> >
On Tue, Sep 7, 2021 at 9:01 PM Daniel Gustafsson wrote:
>
> > On 7 Sep 2021, at 13:36, Peter Eisentraut
> > wrote:
> >
> > On 12.08.21 04:52, Masahiko Sawada wrote:
> >> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson wrote:
> >>>
> On 11 Aug 2021, at 09:57, Masahiko Sawada wrote:
> >>>
> On 7 Sep 2021, at 13:36, Peter Eisentraut
> wrote:
>
> On 12.08.21 04:52, Masahiko Sawada wrote:
>> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson wrote:
>>>
On 11 Aug 2021, at 09:57, Masahiko Sawada wrote:
>>>
Additionally, refresh options as described in
refresh_option
On 12.08.21 04:52, Masahiko Sawada wrote:
On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson wrote:
On 11 Aug 2021, at 09:57, Masahiko Sawada wrote:
Additionally, refresh options as described in
refresh_option of
REFRESH PUBLICATION may be specified,
except in the case of DROP PUBLICATION.
On Thu, Aug 12, 2021 at 12:53 PM Masahiko Sawada wrote:
>
> Yeah, I prefer my original patch over this idea. On the other hand, I
> can see the point of review comment on it that Amit pointed out[1].
>
> Regards,
>
> [1]
> https://www.postgresql.org/message-id/CAA4eK1KaWwUSkDEKPseVY-z00kQJfpfVFdJ
On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson wrote:
>
> > On 11 Aug 2021, at 09:57, Masahiko Sawada wrote:
>
> > Additionally, refresh options as described in
> > refresh_option of
> > REFRESH PUBLICATION may be specified,
> > except in the case of DROP PUBLICATION.
>
> Since this paragraph
> On 11 Aug 2021, at 09:57, Masahiko Sawada wrote:
> Additionally, refresh options as described in
> refresh_option of
> REFRESH PUBLICATION may be specified,
> except in the case of DROP PUBLICATION.
Since this paragraph is under the literal option “refresh”, which takes a
value, I still find y
On Tue, Aug 10, 2021 at 12:28 PM Amit Kapila wrote:
>
> On Tue, Aug 10, 2021 at 6:31 AM Masahiko Sawada wrote:
> >
> > On Mon, Aug 9, 2021 at 1:01 PM Peter Smith wrote:
> > >
> > > On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila
> > > wrote:
> >
> > But "REFRESH PUBLICATION refresh_option" seems w
On Tue, Aug 10, 2021 at 6:31 AM Masahiko Sawada wrote:
>
> On Mon, Aug 9, 2021 at 1:01 PM Peter Smith wrote:
> >
> > On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila wrote:
>
> But "REFRESH PUBLICATION refresh_option" seems wrong in terms of SQL
> syntax, not?
>
> Given there could be multiple option
On Tue, Aug 10, 2021 at 11:01 AM Masahiko Sawada wrote:
>
> On Mon, Aug 9, 2021 at 1:01 PM Peter Smith wrote:
> >
> > On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila wrote:
> > >
> > > On Sun, Aug 8, 2021 at 10:21 AM Peter Smith wrote:
> > > >
> > > > On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila
>
On Mon, Aug 9, 2021 at 1:01 PM Peter Smith wrote:
>
> On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila wrote:
> >
> > On Sun, Aug 8, 2021 at 10:21 AM Peter Smith wrote:
> > >
> > > On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila
> > > wrote:
> > > >
> > > > On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada
On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila wrote:
>
> On Sun, Aug 8, 2021 at 10:21 AM Peter Smith wrote:
> >
> > On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila wrote:
> > >
> > > On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada
> > > wrote:
> > > >
> > > > Hi all,
> > > >
> > > > When reading the d
On Sun, Aug 8, 2021 at 10:21 AM Peter Smith wrote:
>
> On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila wrote:
> >
> > On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada
> > wrote:
> > >
> > > Hi all,
> > >
> > > When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh
> > > options' in the fo
On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila wrote:
>
> On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada wrote:
> >
> > Hi all,
> >
> > When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh
> > options' in the following paragraph is not tagged:
> >
> > ---
> > Additionally, refresh opti
On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada wrote:
>
> Hi all,
>
> When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh
> options' in the following paragraph is not tagged:
>
> ---
> Additionally, refresh options as described under REFRESH PUBLICATION
> may be specified, except i
Hi,
On Thu, Jul 8, 2021 at 10:14 PM Daniel Gustafsson wrote:
>
> > On 8 Jul 2021, at 15:00, Masahiko Sawada wrote:
>
> > I think we can improve it by changing to
> > 'refresh_option'. Thoughts?
>
> My first thought was that the existing wording is clearer, referring to
> “options to refresh”. B
> On 8 Jul 2021, at 15:00, Masahiko Sawada wrote:
> I think we can improve it by changing to
> 'refresh_option'. Thoughts?
My first thought was that the existing wording is clearer, referring to
“options to refresh”. But thinking on it more, it’s easy to see someone
confusing the options part a
Hi all,
When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh
options' in the following paragraph is not tagged:
---
Additionally, refresh options as described under REFRESH PUBLICATION
may be specified, except in the case of DROP PUBLICATION.
---
When I read it for the first time,
21 matches
Mail list logo