Re: Small const correctness patch

2019-09-17 Thread Peter Eisentraut
On 2019-08-08 08:46, Mark G wrote: > Please find attached a trivial patch making a few arrays const (in > addition to the data they point to). committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Small const correctness patch

2019-08-09 Thread Kyotaro Horiguchi
At Thu, 8 Aug 2019 22:56:02 +0300, Mark G wrote in > On Thu, Aug 8, 2019 at 8:51 PM Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> wrote: > > > > How did you find this? Any special compiler settings? > > > > 16 hours stuck in a plane on an international flight. I was just eyeballing

Re: Small const correctness patch

2019-08-08 Thread Ibrar Ahmed
On Fri, Aug 9, 2019 at 1:25 AM Mark G wrote: > > > On Thu, Aug 8, 2019 at 8:25 PM Ibrar Ahmed wrote: > >> +1 >> >> Patch successfully applied to the master ( >> 43211c2a02f39d6568496168413dc00e0399dc2e) >> > > That change looks like an unrelated patch for initdb. I'm still not seeing > my patch

Re: Small const correctness patch

2019-08-08 Thread Mark G
On Thu, Aug 8, 2019 at 8:25 PM Ibrar Ahmed wrote: > +1 > > Patch successfully applied to the master ( > 43211c2a02f39d6568496168413dc00e0399dc2e) > That change looks like an unrelated patch for initdb. I'm still not seeing my patch there. -Mark

Re: Small const correctness patch

2019-08-08 Thread Mark G
On Thu, Aug 8, 2019 at 8:51 PM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > How did you find this? Any special compiler settings? > 16 hours stuck in a plane on an international flight. I was just eyeballing the code to kill the boredom. -Mark

Re: Small const correctness patch

2019-08-08 Thread Peter Eisentraut
On 2019-08-08 08:46, Mark G wrote: > Please find attached a trivial patch making a few arrays const (in > addition to the data they point to). How did you find this? Any special compiler settings? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: Small const correctness patch

2019-08-08 Thread Ibrar Ahmed
+1 Patch successfully applied to the master ( 43211c2a02f39d6568496168413dc00e0399dc2e) On Thu, Aug 8, 2019 at 12:30 PM Mark G wrote: > Hello all, > > Please find attached a trivial patch making a few arrays const (in > addition to the data they point to). > > > -- Ibrar Ahmed

Small const correctness patch

2019-08-08 Thread Mark G
Hello all, Please find attached a trivial patch making a few arrays const (in addition to the data they point to). diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index f553523857..aafc7187b0 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access