On Tue, Sep 26, 2023 at 06:31:42PM +0530, Nishant Sharma wrote:
> To support it I have below points:-
>
> 1) Grepping this table 'test_prepared_savepoint' shows occurrences
> only in twophase.out & twophase.sql files. This means that table is
> local to that sql test file and not used in any other
Hi,
Any taker or rejector for above? -- It's a very small 'good to have' change
patch for cleanup.
Thanks,
Nishant (EDB).
On Tue, Sep 26, 2023 at 6:31 PM Nishant Sharma <
nishant.sha...@enterprisedb.com> wrote:
> Hi,
>
>
> PFA small code cleanup in twophase
Hi,
PFA small code cleanup in twophase.sql. Which contains a drop table
statement for 'test_prepared_savepoint'. Which, to me, appears to be
missing in the cleanup section of that file.
To support it I have below points:-
1) Grepping this table 'test_prepared_savepoint' sh
> On Jun 1, 2020, at 9:59 AM, Tom Lane wrote:
>
> Mark Dilger writes:
>> Yeah, I noticed the `git blame` last night when writing the patch that you
>> had originally wrote the code around 2017, and that the duplication was
>> introduced in a patch committed by others around 2018. I was hop
Mark Dilger writes:
> Yeah, I noticed the `git blame` last night when writing the patch that you
> had originally wrote the code around 2017, and that the duplication was
> introduced in a patch committed by others around 2018. I was hoping that
> you, as the original author, or somebody invol
> On Jun 1, 2020, at 8:53 AM, Tom Lane wrote:
>
> Mark Dilger writes:
>> One line change to remove a duplicate check.
>
> The comment just above this mentions a connection to the "Finish printing
> the footer information about a table" stanza below. I think some work is
> needed to clarify
Mark Dilger writes:
> One line change to remove a duplicate check.
The comment just above this mentions a connection to the "Finish printing
the footer information about a table" stanza below. I think some work is
needed to clarify what's going on there --- it doesn't seem actually
buggy, but th
One line change to remove a duplicate check.
v1-0001-Code-cleanup.patch
Description: Binary data
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
