On 2018-10-02 11:02:37 -0700, Andres Freund wrote:
> On 2018-10-02 18:35:29 +0900, Amit Langote wrote:
> > Hi,
> >
> > I looked at the patch. Some comments.
> >
> > On 2018/10/02 16:35, Andres Freund wrote:
> > > I wasn't quite happy yet with that patch.
> > >
> > > - ConvertTupleSlot seems lik
On 2018-10-02 18:35:29 +0900, Amit Langote wrote:
> Hi,
>
> I looked at the patch. Some comments.
>
> On 2018/10/02 16:35, Andres Freund wrote:
> > I wasn't quite happy yet with that patch.
> >
> > - ConvertTupleSlot seems like a too generic name, it's very unclear it's
> > related to tuple ma
Hi,
I looked at the patch. Some comments.
On 2018/10/02 16:35, Andres Freund wrote:
> I wasn't quite happy yet with that patch.
>
> - ConvertTupleSlot seems like a too generic name, it's very unclear it's
> related to tuple mapping, rather than something internal to slots. I
> went for execut
Hi,
On 2018-09-28 15:36:00 +0530, Amit Khandekar wrote:
> On Wed, 26 Sep 2018 at 03:33, Andres Freund wrote:
> >
> > Hi Amit,
> >
> > Could you rebase this patch, it doesn't apply anymore.
>
> Thanks for informing. Attached are both mine and Amit Langote's patch
> rebased and attached ...
I wasn
On 2018/09/28 19:06, Amit Khandekar wrote:
> On Wed, 26 Sep 2018 at 03:33, Andres Freund wrote:
>>
>> Hi Amit,
>>
>> Could you rebase this patch, it doesn't apply anymore.
>
> Thanks for informing. Attached are both mine and Amit Langote's patch
> rebased and attached ...
Thanks Amit for also ta
On Wed, 26 Sep 2018 at 03:33, Andres Freund wrote:
>
> Hi Amit,
>
> Could you rebase this patch, it doesn't apply anymore.
Thanks for informing. Attached are both mine and Amit Langote's patch
rebased and attached ...
--
Thanks,
-Amit Khandekar
EnterpriseDB Corporation
The Postgres Database Co
Hi Amit,
Could you rebase this patch, it doesn't apply anymore.
Greetings,
Andres Freund
On 3 September 2018 at 12:14, Amit Langote
wrote:
> Hi Amit,
>
> Thanks for the updated patch and sorry I couldn't reply sooner.
>
> On 2018/08/21 16:18, Amit Khandekar wrote:
>> On 21 August 2018 at 08:12, Amit Langote
>> wrote:
>>> Here are some comments on the patch:
>>
>> Thanks for the revi
Hi Amit,
Thanks for the updated patch and sorry I couldn't reply sooner.
On 2018/08/21 16:18, Amit Khandekar wrote:
> On 21 August 2018 at 08:12, Amit Langote
> wrote:
>> Here are some comments on the patch:
>
> Thanks for the review.
>
>>
>> +ConvertTupleSlot
>>
>> Might be a good idea to ca
On 21 August 2018 at 08:12, Amit Langote wrote:
> Here are some comments on the patch:
Thanks for the review.
>
> +ConvertTupleSlot
>
> Might be a good idea to call this ConvertSlotTuple?
I thought the name 'ConvertTupleSlot' emphasizes the fact that we are
operating rather on a slot without ha
On 2018/08/20 20:15, Amit Khandekar wrote:
> On 17 August 2018 at 21:47, Amit Khandekar wrote:
>
>> Attached is a patch tup_convert.patch that does the conversion
>> directly using input and output tuple slots. This patch is to be
>> applied on an essential patch posted by Amit Langote in [1] tha
On 17 August 2018 at 21:47, Amit Khandekar wrote:
> Attached is a patch tup_convert.patch that does the conversion
> directly using input and output tuple slots. This patch is to be
> applied on an essential patch posted by Amit Langote in [1] that
> arranges for dedicated per-partition slots rat
Hi,
In [1] , it was shown that the partition tuples are needlessly formed
and deformed during tuple conversion (do_convert_tuple), when the same
operation can be done using tuple slots. This is because the input
slot might already have a deformed tuple.
Attached is a patch tup_convert.patch that
13 matches
Mail list logo
