I wrote:
> I'm inclined to change this in HEAD but leave it alone in the back
> branches. While it seems pretty bogus, it's not clear if anyone
> out there could be relying on the current behavior.
I've pushed both the 0001 v2 patch and the event trigger change,
and am going to mark the CF entry
Alvaro Herrera writes:
> Oh, you meant this one. To be honest I don't remember *why* this code
> wants to show remote temp tables as just "pg_temp" ... it's possible
> that some test in the DDL-to-JSON code depended on this behavior.
> Without spending too much time analyzing it, I agree that it
On 2021-Jul-26, Tom Lane wrote:
> On the other hand, I don't like 0002 one bit, because it's not accounting
> for whether the temp schema it's mangling is *our own* temp schema or some
> other session's. I do not think it is wise or even safe to report some
> other temp schema as being "pg_temp".
Robert Haas writes:
> On Mon, Jul 26, 2021 at 12:49 PM Tom Lane wrote:
>> I can't really see any situation in which it's important
>> to report the exact schema name of our own temp schema.
> It would actually be nice if there were some easy way of getting that
> for the rare situations in which
On 2021-Jul-26, Tom Lane wrote:
> Alvaro, you seem to be responsible for both the existence of the separate
> get_namespace_name_or_temp function and the fact that it's being avoided
> here. I wonder what you think about this.
The reason I didn't touch get_namespace_name then (e9a077cad379) was
On Mon, Jul 26, 2021 at 12:49 PM Tom Lane wrote:
> I can't really see any situation in which it's important
> to report the exact schema name of our own temp schema.
It would actually be nice if there were some easy way of getting that
for the rare situations in which there are problems. For exam
On Mon, 26 Jul 2021 at 17:49, Tom Lane wrote:
>
> I wrote:
> > Simon Riggs writes:
> >> Surely we need a test to exercise this works? Otherwise ready...
>
> > There are lots of places in the core regression tests where we'd have
> > used a temp table, except that we needed to do EXPLAIN and the r
I wrote:
> Simon Riggs writes:
>> Surely we need a test to exercise this works? Otherwise ready...
> There are lots of places in the core regression tests where we'd have
> used a temp table, except that we needed to do EXPLAIN and the results
> would've been unstable, so we used a short-lived pl
Simon Riggs writes:
> Sounds like a good change.
> Surely we need a test to exercise this works? Otherwise ready...
There are lots of places in the core regression tests where we'd have
used a temp table, except that we needed to do EXPLAIN and the results
would've been unstable, so we used a sho
On Thu, 29 Apr 2021 at 08:17, Amul Sul wrote:
> On Wed, Apr 28, 2021 at 7:56 PM Tom Lane wrote:
> > I don't think we should remove them. However, it could make sense to
> > print the "pg_temp" alias instead of the real schema name when we
> > are talking about myTempNamespace. Basically try to
On Wed, Apr 28, 2021 at 7:56 PM Tom Lane wrote:
>
> Greg Stark writes:
> >> On Tue, Apr 27, 2021 at 7:08 PM Bharath Rupireddy
> >> >> Make sense, we would lose the ability to differentiate temporary
> >> tables from the auto_explain logs.
>
> > There's no useful differentiation that can be done
Greg Stark writes:
>> On Tue, Apr 27, 2021 at 7:08 PM Bharath Rupireddy
>> > Make sense, we would lose the ability to differentiate temporary
>> tables from the auto_explain logs.
> There's no useful differentiation that can be done with the temp
> schema name.
Agreed.
> I would say it makes se
> On Tue, Apr 27, 2021 at 7:08 PM Bharath Rupireddy
> Make sense, we would lose the ability to differentiate temporary
> tables from the auto_explain logs.
There's no useful differentiation that can be done with the temp
schema name. They're assigned on connection start randomly from the
pool of
On Tue, Apr 27, 2021 at 7:08 PM Bharath Rupireddy
wrote:
>
> On Tue, Apr 27, 2021 at 6:59 PM Ashutosh Bapat
> wrote:
> >
> > On Tue, Apr 27, 2021 at 12:23 PM Amul Sul wrote:
> > > >
> > > > How about using an explain filter to replace the unstable text
> > > > pg_temp_3 to pg_temp_N instead of c
On Tue, Apr 27, 2021 at 6:59 PM Ashutosh Bapat
wrote:
>
> On Tue, Apr 27, 2021 at 12:23 PM Amul Sul wrote:
> > >
> > > How about using an explain filter to replace the unstable text
> > > pg_temp_3 to pg_temp_N instead of changing it in the core? Following
> > > are the existing explain filters:
On Tue, Apr 27, 2021 at 12:23 PM Amul Sul wrote:
> >
> > How about using an explain filter to replace the unstable text
> > pg_temp_3 to pg_temp_N instead of changing it in the core? Following
> > are the existing explain filters: explain_filter,
> > explain_parallel_append, explain_analyze_withou
On Tue, Apr 27, 2021 at 11:07 AM Bharath Rupireddy
wrote:
>
> On Tue, Apr 27, 2021 at 10:51 AM Amul Sul wrote:
> >
> > Hi,
> >
> > Temporary tables usually gets a unique schema name, see this:
> >
> > postgres=# create temp table foo(i int);
> > CREATE TABLE
> > postgres=# explain verbose select
On Tue, Apr 27, 2021 at 10:51 AM Amul Sul wrote:
>
> Hi,
>
> Temporary tables usually gets a unique schema name, see this:
>
> postgres=# create temp table foo(i int);
> CREATE TABLE
> postgres=# explain verbose select * from foo;
>QUERY PLAN
> -
Hi,
Temporary tables usually gets a unique schema name, see this:
postgres=# create temp table foo(i int);
CREATE TABLE
postgres=# explain verbose select * from foo;
QUERY PLAN
-
Seq Scan on pg_temp_3.foo
19 matches
Mail list logo
