Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

2025-02-22 Thread Álvaro Herrera
On 2025-Feb-21, Ranier Vilela wrote: > Any chance to push this forward? > Is it worth creating a committfest entry? Yeah, I'll have a look. -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/ "Entristecido, Wutra (canción de Las Barreras) echa a

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

2025-02-21 Thread Ranier Vilela
Em sex., 14 de fev. de 2025 às 10:19, Ranier Vilela escreveu: > Em sex., 14 de fev. de 2025 às 09:13, Ranier Vilela > escreveu: > >> Hi Álvaro. >> >> Em qui., 13 de fev. de 2025 às 18:38, Álvaro Herrera < >> alvhe...@alvh.no-ip.org> escreveu: >> >>> On 2025-Feb-13, Ranier Vilela wrote: >>> >>> >

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

2025-02-14 Thread Ranier Vilela
Em sex., 14 de fev. de 2025 às 09:13, Ranier Vilela escreveu: > Hi Álvaro. > > Em qui., 13 de fev. de 2025 às 18:38, Álvaro Herrera < > alvhe...@alvh.no-ip.org> escreveu: > >> On 2025-Feb-13, Ranier Vilela wrote: >> >> > Hi. >> > >> > Coverity complained about possible dereference null pointer >>

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

2025-02-14 Thread Ranier Vilela
Hi Álvaro. Em qui., 13 de fev. de 2025 às 18:38, Álvaro Herrera < alvhe...@alvh.no-ip.org> escreveu: > On 2025-Feb-13, Ranier Vilela wrote: > > > Hi. > > > > Coverity complained about possible dereference null pointer > > in *reindex_one_database* function. > > That's not really true. > > But the

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

2025-02-13 Thread Álvaro Herrera
On 2025-Feb-13, Ranier Vilela wrote: > Hi. > > Coverity complained about possible dereference null pointer > in *reindex_one_database* function. > That's not really true. > But the logic is unnecessarily complicated. Hmm, this code looks quite suspect, but I wonder if instead of (what looks more

Simplify the logic a bit (src/bin/scripts/reindexdb.c)

2025-02-13 Thread Ranier Vilela
Hi. Coverity complained about possible dereference null pointer in *reindex_one_database* function. That's not really true. But the logic is unnecessarily complicated. Let's simplify it to humans and machines. patch attached. Best regards, Ranier Vilela simplifies-reindex-one-database-reindex