Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em seg., 17 de mar. de 2025 às 16:17, Ranier Vilela escreveu: > Em sex., 7 de mar. de 2025 às 16:14, Ranier Vilela > escreveu: > >> >> >> Em sex., 7 de mar. de 2025 às 16:01, Álvaro Herrera < >> alvhe...@alvh.no-ip.org> escreveu: >> >>> On 2025-Mar-07, Álvaro Herrera wrote: >>> >>> > Anyway, my

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

On 2025-Mar-18, Ranier Vilela wrote: > Thanks Álvaro, for the commit. Thank you for the impetus. -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em seg., 17 de mar. de 2025 às 16:17, Ranier Vilela escreveu: > Em sex., 7 de mar. de 2025 às 16:14, Ranier Vilela > escreveu: > >> >> >> Em sex., 7 de mar. de 2025 às 16:01, Álvaro Herrera < >> alvhe...@alvh.no-ip.org> escreveu: >> >>> On 2025-Mar-07, Álvaro Herrera wrote: >>> >>> > Anyway, my

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em sex., 7 de mar. de 2025 às 16:14, Ranier Vilela escreveu: > > > Em sex., 7 de mar. de 2025 às 16:01, Álvaro Herrera < > alvhe...@alvh.no-ip.org> escreveu: > >> On 2025-Mar-07, Álvaro Herrera wrote: >> >> > Anyway, my version of this is attached. It fixes the problems with your >> > patch, but

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em sex., 7 de mar. de 2025 às 16:01, Álvaro Herrera escreveu: > On 2025-Mar-07, Álvaro Herrera wrote: > > > Anyway, my version of this is attached. It fixes the problems with your > > patch, but not Orlov's fundamental bug. > > And of course I forgot to actually attach the patch. Good grief. >

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Hello I find that this is still quite broken -- both the original, and your patch. I have already complained about a fundamental bug in the original in [1]. In addition to what I reported there, in the unpatched code I noticed that we're wasting memory and CPU by comparing the qualified table na

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em sex., 7 de mar. de 2025 às 15:54, Álvaro Herrera escreveu: > Hello > > I find that this is still quite broken -- both the original, and your > patch. I have already complained about a fundamental bug in the > original in [1]. In addition to what I reported there, in the unpatched > code I no

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

On 2025-Mar-07, Álvaro Herrera wrote: > Anyway, my version of this is attached. It fixes the problems with your > patch, but not Orlov's fundamental bug. And of course I forgot to actually attach the patch. Good grief. -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseD

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em qui., 6 de mar. de 2025 às 15:51, Álvaro Herrera escreveu: > On 2025-Feb-28, Ranier Vilela wrote: > > > v2 attached, please comment if you have any further objections. > > I think running the tests would have been a good idea, as would checking > for compiler warnings. > Hi. Rebased for curren

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

On 2025-Feb-28, Ranier Vilela wrote: > v2 attached, please comment if you have any further objections. I think running the tests would have been a good idea, as would checking for compiler warnings. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "I love the Pos

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Hi Álvaro. Em qui., 27 de fev. de 2025 às 16:50, Álvaro Herrera < alvhe...@alvh.no-ip.org> escreveu: > On 2025-Feb-14, Ranier Vilela wrote: > > > Attached is the prototype version v1. > > What do you think? > > I think this is still a bit confused. The new function's comment says > "prepare the

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

On 2025-Feb-14, Ranier Vilela wrote: > Attached is the prototype version v1. > What do you think? I think this is still a bit confused. The new function's comment says "prepare the list of tables to ..." but what it really receives is a list of _indexes_ (as evidenced by the fact that they're co

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

On 2025-Feb-21, Ranier Vilela wrote: > Any chance to push this forward? > Is it worth creating a committfest entry? Yeah, I'll have a look. -- Álvaro HerreraBreisgau, Deutschland — https://www.EnterpriseDB.com/ "Entristecido, Wutra (canción de Las Barreras) echa a

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em sex., 14 de fev. de 2025 às 10:19, Ranier Vilela escreveu: > Em sex., 14 de fev. de 2025 às 09:13, Ranier Vilela > escreveu: > >> Hi Álvaro. >> >> Em qui., 13 de fev. de 2025 às 18:38, Álvaro Herrera < >> alvhe...@alvh.no-ip.org> escreveu: >> >>> On 2025-Feb-13, Ranier Vilela wrote: >>> >>> >

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em sex., 14 de fev. de 2025 às 09:13, Ranier Vilela escreveu: > Hi Álvaro. > > Em qui., 13 de fev. de 2025 às 18:38, Álvaro Herrera < > alvhe...@alvh.no-ip.org> escreveu: > >> On 2025-Feb-13, Ranier Vilela wrote: >> >> > Hi. >> > >> > Coverity complained about possible dereference null pointer >>

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Hi Álvaro. Em qui., 13 de fev. de 2025 às 18:38, Álvaro Herrera < alvhe...@alvh.no-ip.org> escreveu: > On 2025-Feb-13, Ranier Vilela wrote: > > > Hi. > > > > Coverity complained about possible dereference null pointer > > in *reindex_one_database* function. > > That's not really true. > > But the

Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

On 2025-Feb-13, Ranier Vilela wrote: > Hi. > > Coverity complained about possible dereference null pointer > in *reindex_one_database* function. > That's not really true. > But the logic is unnecessarily complicated. Hmm, this code looks quite suspect, but I wonder if instead of (what looks more

Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Hi. Coverity complained about possible dereference null pointer in *reindex_one_database* function. That's not really true. But the logic is unnecessarily complicated. Let's simplify it to humans and machines. patch attached. Best regards, Ranier Vilela simplifies-reindex-one-database-reindex